Repository navigation
Can't run flutter test on a Mac with prebuilt binaries #1707
Description
We just don't upload the binaries to google storage, but we could.
For now I'm disabling running flutter test tests on our new mac infra.
{{ message }}
We just don't upload the binaries to google storage, but we could.
For now I'm disabling running flutter test tests on our new mac infra.
Activity
eseidelGoogle commentedon Feb 9, 2016
Disabling
flutter teston the mac bots for now: https://codereview.chromium.org/1678283004/abarth commentedon Feb 12, 2016
You can run
flutter teston a mac if you have an engine build. Re-titling.[-]Can't run flutter test on a Mac[/-][+]Can't run flutter test on a Mac with prebuilt binaries[/+]eseidelGoogle commentedon Feb 12, 2016
Just change this one line of code:
https://chromium.googlesource.com/chromium/tools/build.git/+/master/scripts/slave/recipes/flutter/engine.py#141
And we will suddenly have prebuilt binaries for the Mac. :) (uploaded to flutter_infra instead of mojo_infra) I suspect you and I will do that today in our infra handoff.
eseidelGoogle commentedon Feb 19, 2016
I briefly looked at adding this just now. The (small) complexity is that SkyShell.app is a directory and the current UploadArtifacts logic expects files:
https://chromium.googlesource.com/chromium/tools/build.git/+/master/scripts/slave/recipes/flutter/engine.py#48
We can teach it to check if things are files or directories and call AddDirectory instead when necessary.
eseidelGoogle commentedon Feb 19, 2016
https://codereview.chromium.org/1713153002/ was my attempt, likely wrong though.
eseidelGoogle commentedon Feb 23, 2016
My impression is @chinmaygarde may have started on this too.
eseidelGoogle commentedon Apr 12, 2016
Second attempt at adding SkyShell.app to the zip:
https://codereview.chromium.org/1884703002
chinmaygarde commentedon May 19, 2016
Fixed with https://codereview.chromium.org/1991003003
pylaligand commentedon May 19, 2016
Wow, I was just about to file a bug for this as I'm getting:
Thanks!
chinmaygarde commentedon May 19, 2016
@pylaligand You will have to wait a few minutes till #4028 lands.
Ensure that CocoaPods on Cirrus is always the latest version. (flutte…
github-actions commentedon Sep 6, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.