You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that we have golden file testing, it will significantly reduce the churn on our golden files if we test out golden files against scenes that contain no shadows.
Proposal
We add the ability to turn shadows off in the framework. Ideas as to how to do this:
We introduce a debugZeroElevation global in the rendering layer that will cause all elevations to be zero, thus implicitly turning off shadows even though the code to draw the shadows is still active.
We make the flutter test harness turn shadows off by default in all widget tests. Tests that specifically want shadows can update the flag in their test configuration (either via setUp() or flutter_test_config.dart).
We provide a small suite of golden file tests that explicitly enable shadows and test them, so that we can catch regressions in Skia or our own shadow rendering.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
tvolkert commentedon May 3, 2018
/cc @Hixie
Goldens for flutter/flutter#17262
Goldens for flutter/flutter#17262
tvolkert commentedon May 12, 2018
This is fixed with #17363
github-actions commentedon Sep 3, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.