Skip to content

Build gen_snapshot with correct target_os on Windows #17489

Closed
Closed
Build gen_snapshot with correct target_os on Windows#17489
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specifically

Description

@cbracken
cbracken
opened on May 10, 2018

In Windows builds, we override target_os to win. For android-arm and android-arm64 builds of gen_snapshot we should be building with target_os="android". Previously this resulted in #17387.

We should eliminate this override and fix up the rest of the build to correctly support building gen_snapshot (and ideally the engine) on Windows; this would also make it easier for Windows developers to contribute to the engine.

Activity

  1. cbracken
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    engineflutter/engine related. See also e: labels.
    platform-windowsBuilding on or for Windows specifically
    on May 10, 2018

  2. dnfield commented on Aug 10, 2019

    @dnfield
    dnfield
    on Aug 10, 2019
    Contributor

    Is this still the case? It looks like the linked code is no longer that way, and AFAICT we're building gen_snapshot on Windows now.

  3. engine-flutter-autoroll
    added 2 commits that reference this issue on Apr 7, 2020

    098761f Revert "Improve C++ plugin lifetime handling (flutter#17489)" (…

    413eaae

    098761f Revert "Improve C++ plugin lifetime handling (flutter#17489)" (…

    707c7db

  4. markusaksli-nc commented on Oct 15, 2020

    @markusaksli-nc
    markusaksli-nc
    on Oct 15, 2020
    Contributor

    Closing this as it seems done, feel free to reopen if this isn't the case.

  5. markusaksli-nc
    closed this as completedon Oct 15, 2020

  6. github-actions commented on Aug 11, 2021

    @github-actions
    github-actionsbot
    on Aug 11, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: contributor-productivityTeam-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.platform-windowsBuilding on or for Windows specifically

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions