Skip to content

Make SystemChrome updates deterministic #17664

Closed
Closed
Make SystemChrome updates deterministic#17664
Assignees
jonahwilliams
Labels
platform-androidAndroid applications specificallyplatform-iosiOS applications specifically

Description

@jonahwilliams
jonahwilliams
opened on May 16, 2018

Currently we schedule a microtask and update the system chrome to whatever the last value is. This can vary based on which widget subtrees get rebuilt, since it is conventional to call this API in build.

Instead we should always pick an overlay style setting based on the topmost widgets.

Activity

  1. jonahwilliams
    added
    platform-androidAndroid applications specifically
    platform-iosiOS applications specifically
    on May 16, 2018
  2. jonahwilliams
    self-assigned this
    on May 16, 2018

  3. jonahwilliams commented on May 16, 2018

    @jonahwilliams
    jonahwilliams
    on May 16, 2018
    ContributorAuthor

    Explored a solution that involved hitTesting near the very top of the screen, triggered by a special widget. Problems:

    • Only works consistently if the widget is sufficiently early in the tree
    • Blocked by certain parent widgets that handle gestures
    • Page transition animations will build this set of widgets, however the new theme won't be in position to be hitTested until the route animation has completed.
    • Because of above, seems like we would need to do this on every frame.

    I'm looking for a more robust solution.

    cc @HansMuller , @Hixie

  4. goderbauer commented on May 16, 2018

    @goderbauer
    goderbauer
    on May 16, 2018
    Member

    I was just pointed to #4630.

  5. Hixie commented on May 16, 2018

    @Hixie
    Hixie
    on May 16, 2018
    Contributor

    you want to hit test on the layer tree. See #4630 (comment)

  6. jonahwilliams commented on Jun 20, 2018

    @jonahwilliams
    jonahwilliams
    on Jun 20, 2018
    ContributorAuthor

    Closing as a dupe of #4630

  7. jonahwilliams
    closed this as completedon Jun 20, 2018

  8. github-actions commented on Sep 3, 2021

    @github-actions
    github-actionsbot
    on Sep 3, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

platform-androidAndroid applications specificallyplatform-iosiOS applications specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions