flutter_tester --non-interactive should never call beginFrame/drawFrame #178

Activity

1. FlutterIssues

   added

   a: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our tests

   on Nov 9, 2015
2. Hixie commented on Nov 23, 2015

   

   Hixie

   on Nov 23, 2015

   Contributor

   More actions

   I've temporarily worked around this in some of the tests by disconnecting the binding's hook into the engine, but that's not a good long-term solution.
3. Hixie

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   on Dec 12, 2015
4. Hixie

   added this to the Blue SkyThis milestone has been deleted milestone on Dec 12, 2015
5. Hixie commented on Dec 9, 2016

   

   Hixie

   on Dec 9, 2016

   Contributor

   More actions

   @chinmaygarde This bug may be of interest to you. Happy to chat about it if you want.
6. chinmaygarde commented on Dec 9, 2016

   

   chinmaygarde

   on Dec 9, 2016

   Contributor

   More actions

   BeginFrame should only be called if a frame is actually requested. If not, this is likely a bug in the engine. I will can verify it tomorrow.
7. Hixie commented on Dec 9, 2016

   

   Hixie

   on Dec 9, 2016

   Contributor

   More actions

   Oh, cool. I may be able to simplify the test harness then. (This bug is old, it may have changed since I filed it.)
8. Hixie commented on Jan 24, 2017

   

   Hixie

   on Jan 24, 2017

   Last edited by Hixie

   Contributor

   More actions

   @chinmaygarde Looks like the engine is still canning window.onBeginFrame during headless flutter test.

   To check, I edited packages/flutter_test/lib/src/binding.dart; in the initInstances method of the AutomatedTestWidgetsFlutterBinding class, I changed the last line to:

       ui.window.onBeginFrame = (Duration timestamp) { print('engine called onBeginFrame!'); };

   Then I ran flutter test in the flutter_test directory, and observed that it calls that print statement. By checking the stack trace that that closure gets called with (using debugPrintStack) I verified that it is coming from calls to _beginFrame.
9. sethladd

   modified the milestones: 5: Make Hixie proudThis milestone has been deleted, No Milestone NecessaryThis milestone has been deleted on Jan 26, 2017
10. Hixie

    changed the title [-]sky_shell --non-interactive should never call beginFrame[/-] [+]flutter_tester --non-interactive should never call beginFrame[/+] on May 30, 2017
11. Hixie

    changed the title [-]flutter_tester --non-interactive should never call beginFrame[/-] [+]flutter_tester --non-interactive should never call beginFrame/drawFrame[/+] on May 30, 2017
12. Hixie

    closed this as completedon May 30, 2017
13. Hixie commented on May 30, 2017

    

    Hixie

    on May 30, 2017

    Contributor

    More actions

    We have decided we're fine with the current situation either way.
14. Letty-Liang

    added a commit that references this issue on Mar 21, 2019

    Turn icf on for all android builds (flutter#178)

    ...

    2f0e56e
15. github-actions commented on Aug 8, 2021

    

    github-actionsbot

    on Aug 8, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
16. github-actions

    locked as resolved and limited conversation to collaborators on Aug 8, 2021