Skip to content

updateChildren() needs to walk the list forward #182

Closed

Description

@FlutterIssues

Issue by Hixie
Monday Oct 05, 2015 at 21:59 GMT
Originally opened as https://github.com/flutter/engine/issues/1495


When you have a block with multiple focusable controls, the first one needs to get the focus. This means the first one needs to be the first to be built, so it's the first that calls build() and thus the first that calls Focus.at(). However, right now updateChildren() walks the list backwards which means the last child gets the focus.

We probably want to separate the creation of the Element nodes and the setting of the slots from the actual building of the children, somehow, so we can still walk the list backwards to create the slots but walk it forwards to build.

Activity

  1. added this to the milestone on Nov 9, 2015
  2. Hixie commented on Dec 16, 2015

    @Hixie
    Contributor

    Another side-effect of this is that if you have a list of images, we load the images bottom-first. That's weird-looking.

  3. added
    a: text inputEntering text in a text field or keyboard related problems
    on Jan 22, 2016
  4. self-assigned this
    on Jan 26, 2016
  5. github-actions commented on Aug 17, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: text inputEntering text in a text field or keyboard related problemsframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions