Skip to content

Cupertino dialog barrier should be #66000000 #18285

Closed
Closed
Cupertino dialog barrier should be #66000000#18285
Labels
a: fidelityMatching the OEM platforms betterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

Description

@matthew-carroll
matthew-carroll
opened on Jun 7, 2018

Currently the Cupertino dialog shares logic with the material dialog and the barrier color is set to Black54.

The Cupertino dialog should have a black barrier at #66 opacity, AKA #66000000

This ticket is to achieve the desired barrier color, which will require refactoring showDialog() behavior to be different for material vs cupertino.

Activity

  1. chinmaygarde
    added
    a: fidelityMatching the OEM platforms better
    p: cupertino_uicupertino_ui package in flutter/packages
    on Jun 9, 2018
  2. zoechi
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Jul 22, 2018

  3. xster commented on Aug 31, 2018

    @xster
    xster
    on Aug 31, 2018
    Member

    This is done right?

  4. matthew-carroll commented on Aug 31, 2018

    @matthew-carroll
    matthew-carroll
    on Aug 31, 2018
    ContributorAuthor

    I think so. It was Nathalie's work. I didn't get around to reviewing it closely, but I believe she merged in showDialog for Cupertino with updated colors.

  5. xster commented on Aug 31, 2018

    @xster
    xster
    on Aug 31, 2018
    Member

    showCupertinoDialog shows a 0x6604040F barrier. Please re-open if we need further adjustments.

  6. xster
    closed this as completedon Aug 31, 2018

  7. matthew-carroll commented on Aug 31, 2018

    @matthew-carroll
    matthew-carroll
    on Aug 31, 2018
    ContributorAuthor

    @xster this reminds me, we really need to start documenting where we get all the iOS color and style values from. Some come from Apple docs, others are roughly estimated with a color picker from an iOS app. If we ever need to verify then we'll want to know where a given value came from.

  8. xster commented on Sep 1, 2018

    @xster
    xster
    on Sep 1, 2018
    Member

    ya, good point. #21302

  9. engine-flutter-autoroll
    added a commit that references this issue on May 16, 2020

    2494d1c Revert "Remove pipeline in favor of layer tree holder (flutte…

    e2d363c

  10. github-actions commented on Sep 2, 2021

    @github-actions
    github-actionsbot
    on Sep 2, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  11. github-actions
    locked as resolved and limited conversation to collaborators on Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: fidelityMatching the OEM platforms betterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions