Skip to content

Paint functions use save/restore around children #191

Closed

Description

@FlutterIssues

Issue by Hixie
Thursday Oct 08, 2015 at 17:05 GMT
Originally opened as https://github.com/flutter/engine/issues/1537


For example, RenderStack.paint() uses context.canvas.save(); and context.canvas.clipRect(offset & size);. This in theory will fail once things use layers.

There are several problems here:

  • RenderStack.paint() uses save/restore around paintChild.
  • The assert that's supposed to catch this isn't firing.

(Add any other paint() functions that do this to the list above as you find them.)

cc @abarth, @chinmaygarde

Activity

  1. added this to the milestone on Nov 9, 2015
  2. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by abarth
    Friday Oct 23, 2015 at 00:37 GMT


    There are a bunch of these. Grep for context.canvas.save

  3. self-assigned this
    on Nov 19, 2015
  4. added a commit that references this issue on Nov 19, 2015
    d689362
  5. github-actions commented on Aug 17, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

frameworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions