Skip to content

flutter -> packages auto-roller is failing #193231

Closed
flutter/packages
#12994

Description

@elliette

The dart fix --compare-to-golden step in material_ui is failing.

See logs. TLDR; here is the diff:

Expected:
ThemeData themeData = ThemeData.copyWith();

Actual:
ThemeData themeData = ThemeData.copyWith(useMaterial3: false);

Confirmed that this is not a flake and is reproducible locally. Here is where the useMaterial3 parameter is defined. Note that it is deprecated.

The failure started with Roll Dart SDK from ac766ab0aab8 to 0c5772ec6092 (2 revisions) (#193039). Most likely change that caused this in the Dart SDK roll is dart-lang/sdk@bb71ed4.

From my agent:

File a dart-lang/sdk bug against bb71ed43a0ab / CL 551900: deprecated_member_use is no longer reported for named arguments of an invocation that error-recovers as static_access_to_instance_member, which breaks data-driven dart fix for deprecated parameters.

@scheglov I don't understand the changes in bb71ed43a0ab well enough to confirm whether or not that is correct. Does it seem possible that bb71ed43a0ab caused the above changes to deprecated_member_use?

As a workaround to unblock the roll, I will update text_fixes/theme_data.dart to use ThemeData.copyWith(useMaterial3: false) .

Activity

  1. added
    P0Critical issues such as a build break or regression
    on Sep 23, 2026
  2. elliette commented on Sep 23, 2026

    @elliette
    MemberAuthor

    Hmm I think the real issue here is actually that we have incorrect Dart code in test_fixes/theme_data.dart - every instance of ThemeData.copyWith (example) fails to compile with Instance member 'copyWith' can't be accessed using static access.

    I think the real fix here is to replace all the instances of static access copyWith with:

    ThemeData themeData = ThemeData();
    themeData = themeData.copyWith(...);
    

    since it doesn't look like dart fix is expected to fix those issues.

  3. github-actions commented on Oct 8, 2026

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical issues such as a build break or regressionteam-ecosystemOwned by Ecosystem team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions