You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yeah, what we actually need to support is "just" a placeholder rectangle with a paint callback. Then you just hook the rendering boxes into it and can have whatever you want in there.
Reacted by Anatoly Pulyaevskiy, cksac, adu, evanotevil, suragch and Kamal Morjal
@jay7n in regards to this issue (inline images in TextSpan) I didn't have any plans to work on implementing this any time soon. If you're interested in rich-text editor, I've had good progress on it since. But it's just a part of a bigger project and I'm not working on the editor full time.
@pulyaevskiy thanks for your reply and sorry for the delay. I mocked up a quick workaround regarding this missing feature. The idea is simple: detect the images width and the total text size(multiply text count by single font size), and check if there's not enough space for the whole text, then split it to two text widgets, one following the images, the other lay down to next line. All widgets are wrapped in a Wrap widget. I'm not sure this is the right way to do it, but I think the workaround is workable
@exiic I was fixing this issue as a member of Xianyu Team. And as a team we’re currently working on a series of advanced flutter practices, one of which is this “inline-imgs” issue. We’re going to build a group on github and share some code which we think might be worth broadcasting. I’ll let you know once we’re ready~ thank you
Reacted by Anatoly Pulyaevskiy, adu and rockingdice
Status update, currently working on ensuring this change works nicely with the plugins system, and some other misc compatibility issues due to the breaking nature of this change. I will be sure to notify everyone when this feature is fully committed and unlikely to be rolled back, but as of now, it is still rolling in and out of the master branch as we observe the impact of the change.
if you want to experiment with the feature, feel free to work with a snapshot of flutter with the changes in. The feature itself is steady and should be functional.
This change should be (relatively stably) in master as of 938e4eb. The main chunk of changes can be found in c2eaf83. Expecting to roll to dev in a short time. I will close this for now. Please feel free to reopen or provide feedback!
Reacted by Rafael Matsunaga, Đào Hoàng Sơn, Paul Stefan Berbec, savabozo, pokonski, suragch, Rafay Ali, Alann Maulana and enricobenedos
@pulyaevskiy thanks for your reply and sorry for the delay. I mocked up a quick workaround regarding this missing feature. The idea is simple: detect the images width and the total text size(multiply text count by single font size), and check if there's not enough space for the whole text, then split it to two text widgets, one following the images, the other lay down to next line. All widgets are wrapped in a Wrap widget. I'm not sure this is the right way to do it, but I think the workaround is workable
I published package drop_cap_text to achive DropCapText, you can also put an image as custom widget inside DropCap.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
HansMuller commentedon Feb 19, 2016
I think we'll want to support text that contains inline widgets. For example (from the Chips section of the MD spec):
Hixie commentedon Feb 19, 2016
Yeah, what we actually need to support is "just" a placeholder rectangle with a paint callback. Then you just hook the rendering boxes into it and can have whatever you want in there.
namiwang commentedon Jun 29, 2017
I believe flutter also should support inline
Icon/ImageIconinText/TextSpan.I guess this doesn't worth another issue.
Hixie commentedon Jun 29, 2017
Yeah, once we support this you'll be able to put any RenderBox in there.
pulyaevskiy commentedon Jan 2, 2018
This would also be a desirable feature for (future) rich-text editors (I'm currently working on one).
jay7n commentedon Mar 21, 2018
Hi @pulyaevskiy , is there some progress on this issue ? I have encounterd this problem recenetly, and want to get this feature urgently ...
pulyaevskiy commentedon Mar 21, 2018
@jay7n in regards to this issue (inline images in
TextSpan) I didn't have any plans to work on implementing this any time soon. If you're interested in rich-text editor, I've had good progress on it since. But it's just a part of a bigger project and I'm not working on the editor full time.jay7n commentedon Mar 27, 2018
@pulyaevskiy thanks for your reply and sorry for the delay. I mocked up a quick workaround regarding this missing feature. The idea is simple: detect the images width and the total text size(multiply text count by single font size), and check if there's not enough space for the whole text, then split it to two text widgets, one following the images, the other lay down to next line. All widgets are wrapped in a Wrap widget. I'm not sure this is the right way to do it, but I think the workaround is workable
exiic commentedon Jun 8, 2018
Hi @jay7n , can you provide some sample code? Thanks.
jay7n commentedon Jun 13, 2018
@exiic I was fixing this issue as a member of Xianyu Team. And as a team we’re currently working on a series of advanced flutter practices, one of which is this “inline-imgs” issue. We’re going to build a group on github and share some code which we think might be worth broadcasting. I’ll let you know once we’re ready~ thank you
21 remaining items
GaryQian commentedon Jun 4, 2019
Landing process started. Reopening as the main PR has not landed yet.
GaryQian commentedon Jun 4, 2019
Main PR has been moved to #33794 to fix versioning errors
GaryQian commentedon Jun 4, 2019
The feature has landed, but I will keep this open for a little longer just in case it is rolled back since this does contain breaking changes.
GaryQian commentedon Jun 5, 2019
Temporarily reverted due to performance benchmark regressions.
GaryQian commentedon Jun 5, 2019
#33946 Reland PR
GaryQian commentedon Jun 6, 2019
Status update, currently working on ensuring this change works nicely with the plugins system, and some other misc compatibility issues due to the breaking nature of this change. I will be sure to notify everyone when this feature is fully committed and unlikely to be rolled back, but as of now, it is still rolling in and out of the master branch as we observe the impact of the change.
GaryQian commentedon Jun 7, 2019
if you want to experiment with the feature, feel free to work with a snapshot of flutter with the changes in. The feature itself is steady and should be functional.
GaryQian commentedon Jun 7, 2019
#34051 This version contains backwards compatibility API to minimize impact of breaking changes.
GaryQian commentedon Jun 13, 2019
This change should be (relatively stably) in master as of 938e4eb. The main chunk of changes can be found in c2eaf83. Expecting to roll to dev in a short time. I will close this for now. Please feel free to reopen or provide feedback!
[instrumentation_adapter] Update README instructions (flutter#2022)
MstrZeroOne commentedon Jan 4, 2021
I'm using this plugin and I hove an issue: mtiziano/drop_cap_text#14
github-actions commentedon Aug 7, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.