Skip to content

Correct CupertinoAlertDialog divider colors #20469

Closed

Description

@matthew-carroll

After #18381 is merged in and is dedup'd against the similar Action Sheet work, figure out the right colors for the dividers when using the iOS barrier color (initially the dialog work was done against the material barrier color).

Activity

  1. matthew-carroll commented on Aug 14, 2018

    @matthew-carroll
    ContributorAuthor

    Related issue:
    Cupertino dialog barrier should be #66000000 #18285

  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Aug 22, 2018
  3. frey1esm commented on Dec 5, 2018

    @frey1esm

    The divider should be drawn on first rendering. Currently it's not added until the dialog display has reached the end of the show animation. This adds a little flicker.

    Native iOS dialogs resize (shrink) slightly during the show animation, so we're missing that piece.

    In addition, once the divider is shown the white background of the dialog darkens a bit, adding another little flicker.

  4. added this to the milestone on Dec 6, 2018
  5. kerberjg commented on Feb 13, 2019

    @kerberjg
    Contributor

    Currently I'm unable to see the dividers in CupertinoAlertDialog at all, except for some instances. Seems like something's wrong with blending, looks like the dividers are drawn in additive mode.

    The following screenshots are from the Flutter Gallery in Flutter v1.2.0, iOS 12.1.3

    Usual white background, dividers not showing:
    image

    Dividers seem to render in additive, partially blue background:
    image

    While attempting to implement dialogs on my own, I've encountered a similar issue:
    img_e98b3c201b47-1

  6. removed their assignment
    on May 14, 2019
  7. aleor commented on May 30, 2019

    @aleor

    Having the same issue as @kerberjg, am I doing something wrong? Is there any workaround for the issue?

  8. seasonyuu commented on Jul 15, 2019

    @seasonyuu

    Same as @kerberjg here

  9. wezzle commented on Aug 16, 2019

    @wezzle

    Any update on a fix for this? I have the same problem as @kerberjg

    Weird thing though, I did get them to display a few times but can't seem to reproduce this.

  10. jlnr commented on Aug 25, 2019

    @jlnr

    The Cupertino dialog buttons have no pressed/highlighted state either, which makes dialogs feel more like static images right now.

    I think even an inaccurate hotfix like changing _kButtonDividerColor in cupertino/dialog.dart from Color(0x40FFFFFF) to something like Color(0xFFBBBBBB) would be better than the current state where the dividers are only visible on top of dark backgrounds.

  11. kerberjg commented on Aug 27, 2019

    @kerberjg
    Contributor

    Could be related to #39215 (?)

  12. jlnr commented on Sep 5, 2019

    @jlnr

    @kerberjg That PR has been merged, but I still see no dividers on the master channel.

  13. github-actions commented on Aug 15, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  14. locked as resolved and limited conversation to collaborators on Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    frameworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions