Skip to content

VideoPlayer plugin should make sure that resources are released when FlutterView is destroyed #20989

Open
Open
VideoPlayer plugin should make sure that resources are released when FlutterView is destroyed#20989
Labels
P3Issues that are less important to the Flutter projectc: performanceRelates to speed or footprint issues (see "perf:" labels)p: video_playerThe Video Player pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

Description

@nichtverstehen
nichtverstehen
opened on Aug 24, 2018

This is related to #19206 and #19358.

VideoPlayer plugin on Android allocates a platform MediaPlayer object for each VideoPlayer plugin in the widget tree. MediaPlayer objects are destroyed when corresponding Flutter widgets go away. But if a whole FlutterView is destroyed, dispose methods don't run, so MediaPlayer instances are not released. This leads to leaks and also crashes (since the player continues to provide frames for non-existent surfaces; internal bug: b/112692333).

IMO, VideoPlayer should rely on normal disposing for the final cleanup and just assert that by the time the view is destroyed all resources are released. This would rely on widgets disposal methods to be called, which is tracked in #19358.

As a workaround, VideoPlayer should subscribe with a onViewDestroyListener and explicitly release all resources when the owner FlutterView goes away.

Activity

  1. zoechi
    added
    plugin
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    p: first party
    on Aug 24, 2018
  2. zoechi
    added this to the milestone on Aug 24, 2018
  3. nichtverstehen
    added 6 commits that reference this issue on Aug 24, 2018

    Release all resources allocated for VideoPlayers when the owning Flut…

    c908433

    Release all resources allocated for VideoPlayers when the owning Flut…

    54bf55e

    Release all resources allocated for VideoPlayers when the owning Flut…

    93d3f27

    Release all resources allocated for VideoPlayers when the owning Flut…

    7a8affb

    Release all resources allocated for VideoPlayers when the owning Flut…

    de62a61

    Release all resources allocated for VideoPlayers when the owning Flut…

    f531a08
  4. mehmetf
    added a commit that references this issue on Aug 27, 2018

    Release all resources allocated for VideoPlayers when the owning Flut…

    9f80468
  5. nichtverstehen
    added a commit that references this issue on Sep 6, 2018

    Release all resources allocated for VideoPlayers when the owning Flut…

    dea041f
  6. zoechi
    added
    p: video_playerThe Video Player plugin
    on Feb 13, 2019
  7. andreidiaconu
    added a commit that references this issue on Feb 17, 2019

    Release all resources allocated for VideoPlayers when the owning Flut…

    e235935
  8. ryanheise
    added a commit that references this issue on Sep 29, 2019

    Release all resources allocated for VideoPlayers when the owning Flut…

    85e4402

  9. 9 remaining items

  10. maheshj01
    added
    passed first triage
    on Jul 7, 2021
  11. stuartmorgan-g
    removed
    p: first party
    on Feb 10, 2023
  12. flutter-triage-bot
    added
    P3Issues that are less important to the Flutter project
    and removed
    P6
    on Jun 28, 2023
  13. flutter-triage-bot
    added
    packageflutter/packages repository. See also p: labels.
    on Jul 5, 2023
  14. Hixie
    removed
    plugin
    on Jul 6, 2023
  15. flutter-triage-bot
    added
    team-ecosystemOwned by Ecosystem team
    triaged-ecosystemTriaged by Ecosystem team
    on Jul 8, 2023
  16. Hixie
    removed
    passed first triage
    on Jul 8, 2023
  17. auto-submit
    added a commit that references this issue on Apr 16, 2024

    [video_player] Calls `onDestroy` instead of `initialize` in onDetache…

    b2bd8e5
  18. TecHaxter
    added a commit that references this issue on May 22, 2024

    [video_player] Calls `onDestroy` instead of `initialize` in onDetache…

    059747f
  19. zhouyuanbo
    added a commit that references this issue on May 24, 2024

    [video_player] Calls `onDestroy` instead of `initialize` in onDetache…

    003274c
  20. creatorpiyush
    added a commit that references this issue on Jun 10, 2026

    [video_player] Calls `onDestroy` instead of `initialize` in onDetache…

    9485b4f
  21. bisor0627
    added a commit that references this issue on Jun 19, 2026

    [video_player] Calls `onDestroy` instead of `initialize` in onDetache…

    1256ccf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: performanceRelates to speed or footprint issues (see "perf:" labels)p: video_playerThe Video Player pluginpackageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions