Skip to content

dart:ui should have a method to push the data to the GPU #212

Closed
Closed
dart:ui should have a method to push the data to the GPU#212
Assignees
abarth
Labels
c: new featureNothing broken; request for a new capabilityengineflutter/engine related. See also e: labels.

Description

@FlutterIssues
FlutterIssues
opened on Nov 9, 2015

Issue by Hixie
Monday Oct 19, 2015 at 22:58 GMT
Originally opened as https://github.com/flutter/engine/issues/1682

...so that we can call it during the frame as soon as we have the data ready, before we deal with cleanup, scheduling the next frame's animations, etc.

If we do that, we can move the call to GlobalKey._notifyListeners() in Element.finalizeTree() to just be an inline call rather than a call through scheduleMicrotask().

Activity

  1. FlutterIssues
    added this to the milestone on Nov 9, 2015
  2. FlutterIssues
    added
    engineflutter/engine related. See also e: labels.
    c: new featureNothing broken; request for a new capability
    on Nov 9, 2015

  3. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    FlutterIssues
    on Nov 9, 2015
    Author

    Comment by abarth
    Wednesday Oct 28, 2015 at 14:18 GMT

    ui.window.render now lets you signal that you want to push to the GPU but it's not wired up to do that in C++ yet.

  4. Hixie commented on Dec 26, 2015

    @Hixie
    Hixie
    on Dec 26, 2015
    Contributor

    Specifically all it does now is:

    void SkyView::Render(Scene* scene) {
  layer_tree_ = scene->takeLayerTree();
}

  5. Hixie commented on Dec 26, 2015

    @Hixie
    Hixie
    on Dec 26, 2015
    Contributor

    Animator::BeginFrame does the actual pushing:

    rasterizer_->Draw(reinterpret_cast<uint64_t>(layer_tree.release()),
      base::Bind(&Animator::OnFrameComplete, weak_factory_.GetWeakPtr()));

  6. abarth commented on Dec 27, 2015

    @abarth
    abarth
    on Dec 27, 2015
    Contributor

    Yeah, we need to flip things around on the C++ side so that SkyView::Render actually sends the layer tree to the GPU thread.

  7. abarth
    self-assigned this
    on Apr 20, 2016

  8. abarth commented on Apr 20, 2016

    @abarth
    abarth
    on Apr 20, 2016
    Contributor

    Will be fixed in flutter-team-archive/engine#2603

  9. abarth
    closed this as completedon Apr 20, 2016
  10. Letty-Liang
    added a commit that references this issue on Mar 21, 2019

    Enable coverage builds on Linux host. (flutter#212)

    058c6d9

  11. github-actions commented on Aug 17, 2021

    @github-actions
    github-actionsbot
    on Aug 17, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  12. github-actions
    locked as resolved and limited conversation to collaborators on Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: new featureNothing broken; request for a new capabilityengineflutter/engine related. See also e: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions