Skip to content

☂️ Menu bars and cascading menus #23600

Closed
Closed
☂️ Menu bars and cascading menus#23600
Assignees
gspencergoog
Labels
P2Important issues not at the top of the work lista: desktopRunning on desktopc: new featureNothing broken; request for a new capabilitycustomer: fuchsiaframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesplatform-chromebookChromebook applications specifically

Description

@gspencergoog
gspencergoog
opened on Oct 27, 2018

For some embeddings (macOS, Windows, Linux, ChromeOS, Fuschia), an application-level menu bar widget is necessary. It should be able to display keyboard accelerators, menu item separators, and have cascading menus.

The design doc is here: https://flutter.dev/go/cascading-menus
The draft Framework PR is here: #109179
The draft Engine PR is here: flutter-team-archive/engine#31124
This PR is part of the overall effort to support Material 3 - #91605

The current burndown list for implementing the Material menu bar:

  • Basic prototype, menus can be defined, open and close.
  • Design doc update
  • Convert overlay usage into regular Stack
  • Figure out how to add all menus offstage initially to allow activator registration.
  • Hover support
  • Activator support
  • Keyboard navigation support
  • RTL support
  • Visual Density support
  • Platform system menu plugin support for macOS
  • Platform default menu item support (basic)
  • Screen placement and scrolling on small windows.
  • Confirm semantics support (with tests) for cascading menus and menubars #127617
  • unit tests x1000
  • API docs update
  • Final formatting pass
  • Add examples and example tests
  • Connect activators and keyboard support with Shortcuts and Actions?

Activity

  1. gspencergoog
    added
    c: new featureNothing broken; request for a new capability
    customer: fuchsia
    platform-chromebookChromebook applications specifically
    on Oct 27, 2018
  2. zoechi
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Dec 11, 2018
  3. zoechi
    added this to the milestone on Dec 11, 2018
  4. gspencergoog
    added
    a: desktopRunning on desktop
    on Mar 11, 2019

  5. stuartmorgan-g commented on Mar 12, 2019

    @stuartmorgan-g
    stuartmorgan-g
    on Mar 12, 2019
    Contributor

    FDE has a plugin that partially implements this (accelerators aren't implemented yet, but separators and nesting are). We could potentially use that as a starting point for something that's in-Framework.

  6. gspencergoog
    assigned
    gspencergoog
    and
    franciscojma86
    and unassigned
    gspencergoog
    on Oct 16, 2019
  7. gspencergoog
    changed the title [-]Menu bar support[/-] [+]Menu bar support for desktop platforms.[/+] on Dec 4, 2019
  8. franciscojma86
    removed their assignment
    on Jan 23, 2020
  9. kf6gpe
    added
    P2Important issues not at the top of the work list
    on May 29, 2020
  10. Hixie
    removed this from the milestone on Aug 17, 2020
  11. gspencergoog
    self-assigned this
    on Feb 23, 2022

  12. 4 remaining items

  13. guidezpl
    added this to Material 3on May 23, 2022
  14. guidezpl
    moved this to Todo in Material 3on May 23, 2022
  15. guidezpl
    moved this from Todo to In Progress in Material 3on May 23, 2022
  16. cbracken
    added this to Flutter Desktopon May 24, 2022
  17. cbracken
    moved this to In Progress in Flutter Desktopon May 24, 2022

  18. gspencergoog commented on Oct 3, 2022

    @gspencergoog
    gspencergoog
    on Oct 3, 2022
    ContributorAuthor

    The main implementation for menus has been committed. Check out the MenuAnchor and MenuBar classes.

    There are still some tasks to do here (accelerators, some theme work, etc.), but the basics work.

  19. gspencergoog commented on Oct 3, 2022

    @gspencergoog
    gspencergoog
    on Oct 3, 2022
    ContributorAuthor

    We're also planning to do some evaluation of the various different menu types and themes to see where we can merge them to share implementations, etc.

  20. cmedamine commented on Oct 7, 2022

    @cmedamine
    cmedamine
    on Oct 7, 2022

    @gspencergoog are these native-like electron js menus?

  21. gspencergoog commented on Oct 7, 2022

    @gspencergoog
    gspencergoog
    on Oct 7, 2022
    ContributorAuthor

    @cmedamine These are Material-style menus rendered by Flutter. I've never used Electron, so I'm not sure if they're comparable, but probably.

  22. gspencergoog commented on Jun 9, 2023

    @gspencergoog
    gspencergoog
    on Jun 9, 2023
    ContributorAuthor

    Closing this umbrella issue because menus are now implemented. We'll file specific issues for any bugs or missing features.

  23. gspencergoog
    closed this as completedon Jun 9, 2023
  24. github-project-automation
    moved this from 🚧 In Progress to ✅ Done in Material 3on Jun 9, 2023
  25. github-project-automation
    moved this from In Progress to Done in Flutter Desktopon Jun 9, 2023

  26. github-actions commented on Jun 23, 2023

    @github-actions
    github-actionsbot
    on Jun 23, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  27. github-actions
    locked as resolved and limited conversation to collaborators on Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: desktopRunning on desktopc: new featureNothing broken; request for a new capabilitycustomer: fuchsiaframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packagesplatform-chromebookChromebook applications specifically

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions