Skip to content

Reconsider BottomNavigationBar API given updated spec? #27414

Closed

Description

@marcoms

With #27008, the two bar types look more similar (besides the color), and AFAICT the spec doesn't seem to make a distinction between 'shifting' and 'fixed' bottom navigation bars. I also don't know if changing the bottom nav color used to be on the spec, but it's not as of reading today.

Reading through the section on material.io, we see a mixture of different styles and behaviors not necessarily put into certain buckets. For example, the following is the first image on the bottom nav section:

mio-design_assets_1h5m0bgm_lfxii-6ho4jisem0bcwvg0gl_bottomnav-usage-1

Which currently isn't possible with Flutter since elements of this design are split betwen fixed and shifting modes. See also:

mio-design_assets_0b6xusjjsulxcavpemk5tz2rgz3c_bottomnav-badging-1

We have the same problem here: our shifting mode renders icons and text in white, since it assumes the background will be a contrasting color.

Seems to me like it makes sense to update the API to allow users to control each of these aspects (shifting, inactive labels hidden, inactive opacity, background color, foreground color, etc.) individually.

Thoughts?

Activity

  1. HansMuller commented on Feb 4, 2019

    @HansMuller
    Contributor
  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: material_uimaterial_ui package in flutter/packages
    on Feb 7, 2019
  3. added this to the milestone on Feb 7, 2019
  4. github-actions commented on Aug 14, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    frameworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions