[Material] Expand BottomNavigationBar API (reprise) by HansMuller · Pull Request #28159 · flutter/flutter

HansMuller · 2019-02-19T19:45:28Z

These changes come from @johnsonmh in #27698.
This PR also incorporates work done by @hyochan in #22956.

Expand the BottomNavigationBar API.

Add the ability to customize the following fields on BottomNavigationBars:

backgroundColor
elevation
selectedItemColor
unselectedItemColor
selectedFontSize
unselectedFontSize
showSelectedLabels
showUnselectedLabels

Combining these fields allows users to create BottomNavigationBars that match the current Material Design specifications, as well as support other requested features.

The default behavior of BottomNavigationBar is still the same:

`Fixed`	`Shifting`

Custom font size

Using custom selectedFontSize and unselectedFontSize, the BottomNavigationBar now still animates properly.

`Fixed`	`Shifting`

Custom Coloring

Using custom backgroundColor,selectedItemColor, and unselectedItemColor, the BottomNavigationBar can be customized.

Note: shifting BottomNavigationBars respect the color of their BottomNavigationBarItems rather than use the BottomNavigationBar's backgroundColor, this preserves the "ripple" behavior.

`Fixed`	`Shifting`

Hide/Show labels

Being able to optionally hide/show selected and unselected labels on fixed BottomNavigationBars allows us to get behavior described in the Material spec.


`showSelectedLabels && showUnselectedLabels`
`showSelectedLabels && !showUnselectedLabels`
`!showSelectedLabels && !showUnselectedLabels`

Closes #23178
Closes #27414
Closes #17099
Closes #25895
Closes #22882
Closes #27739
Closes #27651

googlebot · 2019-02-19T19:45:31Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

gspencergoog · 2019-02-19T21:36:50Z

Couldn't you wrap this in a ReverseAnimation instead?

I think so, however I find this (I didn't write this) easier to understand.

Really? Because this seems a lot clearer to me (at least it would be to a newbie):

Suggested change

opacity: Tween<double>(begin: 1.0, end: 0.0).animate(animation),

opacity: ReverseAnimation(animation),

The documentation for ReverseAnimation says:

Using a ReverseAnimation is different from simply using a Tween with a begin of 1.0 and an end of 0.0 because the tween does not change the status or direction of the animation.

So what are the implications of changing the animation's direction or status (he asked rhetorically). While I'm scratching my head the person reading Tween<double>(begin: 1.0, end: 0.0) has already moved on.

Well, but you could just as well scratch your head about what the .animate on the Tween does. Or the fact that a Tween isn't an animation, but you're assigning to one.

It's OK to keep it as a Tween, it's not a big deal, but I disagree that it's clearer.

Co-authored-by: MH Johnson <[email protected]> Co-authored-by: Hyo Chan Jang <[email protected]>

DeRealMorgan · 2019-03-07T18:12:26Z

How can I get this update to my flutter regularly ? I am running the newest version of the flutter plugin.

gisinator · 2019-05-15T10:01:18Z

Thank you guys for these new features, they look very promising. According to the docs:
https://docs.flutter.io/flutter/material/BottomNavigationBar-class.html
I can already use those, e.g. showSelectedLabels.

But when I try them in my AndroidStudio, I get "isnt defined" error. So, to me it looks like I cannot use them yet.

What am I missing? :)

frey1esm · 2019-05-16T14:25:09Z

Thank you guys for these new features, they look very promising. According to the docs:
https://docs.flutter.io/flutter/material/BottomNavigationBar-class.html
I can already use those, e.g. showSelectedLabels.

But when I try them in my AndroidStudio, I get "isnt defined" error. So, to me it looks like I cannot use them yet.

What am I missing? :)

@gisinator Make sure your settings are under BottomNavigationBar and not BottomNavigationBarItem.

gisinator · 2019-05-16T14:34:52Z

thank you, @frey1esm , but I am afraid that's exactly what I did:

Or did I do anything wrong? :)

frey1esm · 2019-05-16T14:44:49Z

Or did I do anything wrong? :)

Looks good from here. What is your Flutter version?

Also, this won't work with the CupertinoTabBar theme AFAIK.

gisinator · 2019-05-16T14:53:33Z

Thank you sir, looks like this was the issue :)

Until now I thought that Android Studio took care of updating the whole stuff. Every now and then I agreed on upating AndroidStudio, Dart, Emulator and so on.

Didnt know I had to update Flutter version by myself and just went from 1.21 to 1.54-hotfix.2
Now those parameters work as expected.

Thank you @frey1esm , your help was appreciated :)

googlebot added the cla: no label Feb 19, 2019

This was referenced Feb 19, 2019

[Material] Expand BottomNavigationBar API #27698

Closed

[FR] BottomNavigationBar fixed with no titles. #22956

Closed

hyochan mentioned this pull request Feb 19, 2019

Fixed touch area of bottom navigation bar to be filled. #22685

Closed

gspencergoog requested changes Feb 19, 2019

View reviewed changes

zoechi added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Feb 20, 2019

gspencergoog approved these changes Feb 20, 2019

View reviewed changes

HansMuller and others added 4 commits February 20, 2019 15:56

[Material] Expand BottomNavigationBar API flutter#27698

fa920c1

Co-authored-by: MH Johnson <[email protected]> Co-authored-by: Hyo Chan Jang <[email protected]>

removed the fixedColor field, etc

bd23e14

example code: selectedColor => selectedItemColor

5fff76b

updated per review feedback

a1de2f4

HansMuller force-pushed the mh_bottom_navigation_bar branch from f23b7ad to a1de2f4 Compare February 21, 2019 00:10

HansMuller merged commit 617ca62 into flutter:master Feb 22, 2019

HansMuller deleted the mh_bottom_navigation_bar branch February 22, 2019 00:05

johnsonmh added a commit to flutter-team-archive/goldens that referenced this pull request Mar 4, 2019

Remove old goldens after flutter/flutter#28159

154ee90

github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021

	opacity: Tween<double>(begin: 1.0, end: 0.0).animate(animation),
	opacity: ReverseAnimation(animation),

Conversation

HansMuller commented Feb 19, 2019

Expand the BottomNavigationBar API.

The default behavior of BottomNavigationBar is still the same:

Custom font size

Custom Coloring

Hide/Show labels

Uh oh!

googlebot commented Feb 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gspencergoog Feb 19, 2019

Choose a reason for hiding this comment

Uh oh!

HansMuller Feb 19, 2019

Choose a reason for hiding this comment

Uh oh!

gspencergoog Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

HansMuller Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

gspencergoog Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DeRealMorgan commented Mar 7, 2019

Uh oh!

gisinator commented May 15, 2019

Uh oh!

frey1esm commented May 16, 2019

Uh oh!

gisinator commented May 16, 2019

Uh oh!

frey1esm commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gisinator commented May 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

frey1esm commented May 16, 2019 •

edited

Loading