Skip to content

Add initial 'doctor' support for desktop platforms #31368

Closed

Description

@stuartmorgan-g

When the desktop support flag is enabled we should add checks for the current host to flutter doctor.

Currently since the build script is completely unopinionated (just running a shell script) we don't know all the things we'll want to add yet, but there are some things we could start with that we can be pretty confident will be necessary:

  • On macOS, ensure that Xcode is installed, including command line build support.
  • On Windows, ensure that VS code is installed and vcvars64.bat is locatable (for doing command-line builds)

For Linux we'll eventually want to check for the compiler and relevant libraries, but that will require decisions about what toolchain we're going to use for the created project on Linux. For now, we can just add the scaffolding for Linux without any checks.

CC @jonahwilliams

Activity

  1. added
    platform-macosBuilding on or for macOS specifically
    platform-windowsBuilding on or for Windows specifically
    t: flutter doctorProblem related to the "flutter doctor" tool
    platform-linuxBuilding on or for Linux specifically
    on Apr 20, 2019
  2. stuartmorgan-g commented on Apr 20, 2019

    @stuartmorgan-g
    ContributorAuthor

    Note on VS: there have been several cases in FDE of people having VS installed, but not the desktop and/or C++ development modules workload. We should check for VS in general separately from the specific support pieces needed, with different error messages. We'll need to check what the names of the required pieces are in the installer, since I forget the exact names. According to the VS docs, the workload in question is called "Desktop development with C++". (Down the road we'll likely need "Universal Windows Platform development" as well, for the real Windows shell.)

  3. stuartmorgan-g commented on May 24, 2019

    @stuartmorgan-g
    ContributorAuthor

    macOS will be mostly done with the PR above, but as a follow-up we'll need to check for a higher version of Xcode than the current check, and warn that iOS development will work but macOS won't if the version is between the two.

  4. stuartmorgan-g commented on Jul 1, 2019

    @stuartmorgan-g
    ContributorAuthor

    #34755 was the last piece of this; specific updates (like Xcode version) will be tracked in individual bugs.

  5. github-actions commented on Aug 29, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: desktopRunning on desktopplatform-linuxBuilding on or for Linux specificallyplatform-macosBuilding on or for macOS specificallyplatform-windowsBuilding on or for Windows specificallyt: flutter doctorProblem related to the "flutter doctor" tool

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions