Repository navigation
Add linux doctor implementation - #34755
Merged
Merged
Conversation
added 14 commits
April 30, 2019 14:57
dnfield
added
t: flutter doctor
dnfield
reviewed
Jun 20, 2019
| if (clangResult.exitCode != 0) { | ||
| ProcessResult clangResult; | ||
| try { | ||
| clangResult = await processManager.run(const <String>[ |
Contributor
There was a problem hiding this comment.
This does do a bit more than processManager.canRun - but is that intended? Is canRun not good enough here?
Contributor
Author
There was a problem hiding this comment.
I could be wrong but I've seen canRun throw argument errors too
dnfield
approved these changes
Jun 20, 2019
dnfield
left a comment
dnfield
left a comment
Contributor
There was a problem hiding this comment.
LGTM, as long as we really do need to execute clang++ and make and can't just check that they are available on the path.
Contributor
Author
|
We'd need to check for them on the path and then execute with --version to check that. This combines that into a single call, which nicely simplifies the code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #31873