Repository navigation
Add tools measurements for add-to-app #32649
Description
- Add a secondary dimension to the flutter run GA screen to see if it's being invoked in an app type project or a module type project
- Track flavours of flutter create as a dimension app/plugin/module, java/kotlin/objc/swift, any sample template
- Track flutter packages get context as a dimension. Is it in an app or module. Success or failure. Would be nice to add it both as a screen and as an app event (with timing).
- In flutter packages, would be nice to break out the number of plugins as another dimension.
- Track invocations of include_flutter.groovy, podhelper.rb and xcode_backend.sh build and embed. Success/failure dimensions. Dart snapshot cache hit as a dimension. Add timing as well in GA.
- Track flutter attach success/failure.
Generally, avoid PII such as project names etc.
Feel free to add additional information you think is valuable for future analysis.
Activity
xster commentedon May 22, 2019
Worth also running through an add-to-app test run one time to make sure that all the reportings' mutual overlap/exclusion is sensible.
xster commentedon Jun 4, 2019
Was the PR reverted?
blasten commentedon Jun 4, 2019
It was merged back: #33458
xster commentedon Jun 8, 2019
Small note: related to #32992 that we talked a bit about on Thursday, I think cd18 isn't right. It checks for people running
flutter runin the wrapper projects though most likely developers won't do that. They'll be running include_flutter.groovy, flutter.gradle, podhelper.rb and xcode_backend.sh build and embed etc.xster commentedon Jun 8, 2019
Actually I think we'll need that part. Otherwise we won't have any middle-of-the-funnel level engagement signals from add-to-app'ers which at the moment is the pull-up mechanisms from the various gradle/xcode scripts.
blasten commentedon Jun 10, 2019
@xster the
include_flutter.groovyflow only talks to the tool to generate the aot snapshots, and the bundle. What about we register whenflutter build aotis called on a module project?xster commentedon Jun 10, 2019
ha, I was just thinking about how we would concretely implement this and wad going to recommend the same thing. SGTM!
We'd anticipate wanting to call flutter build aot for our future flutter build aar/framework too so we should plan ahead on annotating the pull-up experienced ahead of time.
blasten commentedon Jun 14, 2019
Closing, since this is fully implemented now!
github-actions commentedon Aug 28, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.