Repository navigation
Add to app measurement - #33458
Merged
Merged
Add to app measurement#33458
Conversation
…to_app_measurement
goderbauer
added
the
tool
…to_app_measurement
zanderso
reviewed
Jun 3, 2019
| assert(result != null); | ||
| } | ||
| if (result != 0) | ||
| if (result == 0) { |
Member
There was a problem hiding this comment.
Why not report success/failure for every command here:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/runner/flutter_command.dart#L442 ?
Contributor
There was a problem hiding this comment.
That's good idea, we can filter down the attach success specifically from that, but it will give us other good information too.
cc @blasten
This was referenced Jun 3, 2019
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#33450 was merged, therefore I'm resending this PR.
Instrument add to app flows, so we can get an estimate of how the tool is used in this context.
Related Issues
#32649
Tests
I added the following tests:
project.ios.isSwiftandproject.android.isKotlintest/commands/create_test.dart,test/commands/packages_test.dartChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?