Document how to update flutter #329
Copy link
Copy link
Closed
Description
In /sky_engine-0.0.49/sdk_ext/Customwindow.dart:
...
9: typedef void _EventCallback(Event event);
...
In /flutter/packages/flutter/lib/src/rendering/binding.dart:
...
146: ui.window.onEvent = _handleEvent;
...
207: void _handleEvent(String eventType, double timeStamp) {...}
...
Commit: c94e4c4
So I get on app start:
org.domokit.sky.shell E/chromium: [ERROR:dart_error.cc(16)] Unhandled exception:
type '(String, double) => void' is not a subtype of type '_EventCallback' of 'value'.
#0 Window.onEvent= (file:///src/flutter/engine/src/out/android_Release/gen/sky/bindings/Customwindow.dart:33)
#1 FlutterBinding.FlutterBinding (packages/flutter/src/rendering/binding.dart:146)
#2 WidgetFlutterBinding.WidgetFlutterBinding (packages/flutter/src/widgets/binding.dart:12)
#3 WidgetFlutterBinding.ensureInitialized (packages/flutter/src/widgets/binding.dart:19)
#4 runApp (packages/flutter/src/widgets/binding.dart:82)
#5 main (/Users/ivbaranov/Projects/flutter/flutter/examples/fitness/lib/main.dart:165)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
IvBaranov commentedon Nov 12, 2015
Sorry, that is kind of obvious that I should update sky_engine package first:
pub get sky_engineIvBaranov commentedon Nov 12, 2015
However there should be the same kind of error when one followed Getting Started with Flutter:
while alpha is far behind the c94e4c4, where
sky_enginemethod parameters change took place.abarth commentedon Nov 12, 2015
Each git revision of flutter.git specifies exactly which revision of the engine it is compatible with. If you clone the alpha branch and then
pub upgradeyour app, you'll get a version of the engine that is compatible with that version ofpackage:flutter.If you build the engine from source yourself, then you need to worry about whether the engine you've built locally is compatible with the version of
package:flutterthat you're working with. However, most people shouldn't need to build the engine from source.abarth commentedon Nov 12, 2015
Maybe the bug here is to better document how to update flutter once you've got it?
[-]Handle event arguments[/-][+]Document how to update flutter[/+]abarth commentedon Nov 12, 2015
First step in #331
IvBaranov commentedon Nov 12, 2015
It's clear now, thanks!
abarth commentedon Nov 12, 2015
Docs are in https://github.com/flutter/flutter.github.io/pull/84
Upgrade command pushed to
alpha.github-actions commentedon Sep 7, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.