Skip to content

BottomNavigationBar Golden File Test Uses Incorrect Versioning #33845

Closed
#33865
Closed
BottomNavigationBar Golden File Test Uses Incorrect Versioning#33845
#33865
Assignees
Piinks
Labels
a: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Description

@Piinks
Piinks
opened on Jun 4, 2019

The golden file tests for

BottomNavigationBar shifting backgroundColor with transition

use a version number out of place from the normal conventions that are followed in the flutter/goldens repository. Keeping uniformity in versioning files is crucial for fixing #33813.
The version number in the tests here need to be moved to the end of the file name.
See test here.
This is the only golden file test that does not follow the versioning format explained here, all others have been validated.

  • Wiki will need to be updated to specify the versioning format explicitly.

Activity

  1. Piinks
    self-assigned this
    on Jun 4, 2019
  2. Piinks
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    a: tests"flutter test", flutter_test, or one of our tests
    on Jun 4, 2019
  3. Piinks
    added a commit that references this issue on Jun 4, 2019

    Goldens for flutter/flutter#33845

    ba594de
  4. HansMuller
    added
    p: material_uimaterial_ui package in flutter/packages
    on Jun 4, 2019
  5. Piinks
    added a commit that references this issue on Jun 4, 2019

    Updating obsolete files for flutter/flutter#33845

    c1edd8e
  6. Piinks
    closed this as completedin #33865on Jun 6, 2019

  7. github-actions commented on Aug 29, 2021

    @github-actions
    github-actionsbot
    on Aug 29, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. github-actions
    locked as resolved and limited conversation to collaborators on Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsframeworkflutter/packages/flutter repository. See also f: labels.p: material_uimaterial_ui package in flutter/packages

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions