Skip to content

Images are uploaded to the GPU synchronously #3805

Closed

Description

@Hixie

This trace: #3082 (comment)
...includes a 300ms frame which we suspect corresponds to the frame during which we upload images to the GPU.

To reproduce, open the gallery app and run the Weather demo.

I'd like us to use a solution that keeps the developer in control, i.e. not one that always replaces loading images with a checkboard or some such. We could solve this in various ways, maybe a function that says "pin this to the GPU" and returns a Future that resolves when it's ready (but then how do you handle eviction?); maybe the function that takes the image (drawImage and friends) would also optionally return a bool, and if the bool is false (meaning that the image won't be painted this frame in all likelihood) you'd be able to paint something cheaper that frame. We'd also need a way to retrigger a paint once an image was uploaded (maybe a Future again).

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    engineflutter/engine related. See also e: labels.
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on May 9, 2016
  2. added this to the milestone on May 9, 2016
  3. modified the milestones: Gallery App, on May 10, 2016
  4. modified the milestones: , Gallery App on May 23, 2016
  5. sethladd commented on May 23, 2016

    @sethladd
    Contributor

    Blocked #3478

  6. modified the milestones: Next, on Jun 3, 2016
  7. self-assigned this
    on Jun 3, 2016
  8. eseidelGoogle commented on Jun 17, 2016

    @eseidelGoogle
    Contributor

    I spoke with @abarth just now. It will probably be a while before we tackle this. That could change with more examples, but for now expect this to be a few months away.

  9. eseidelGoogle commented on Jul 19, 2016

    @eseidelGoogle
    Contributor

    I also mentioned this to @jason-simmons today in case he's interested in more meaty engine work.

  10. eseidelGoogle commented on Jul 26, 2016

    @eseidelGoogle
    Contributor

    I just spoke with @chinmaygarde and he's willing to tackle this asap.

  11. sethladd commented on Jul 26, 2016

    @sethladd
    Contributor

    Thanks @chinmaygarde !

  12. modified the milestones: August, Next on Aug 1, 2016
  13. sethladd commented on Aug 3, 2016

    @sethladd
    Contributor

    I believe we landed this. There are some bugs, but I think we can close.

  14. github-actions commented on Sep 6, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  15. locked as resolved and limited conversation to collaborators on Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: performanceRelates to speed or footprint issues (see "perf:" labels)customer: fast (g3)customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.engineflutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions