[google_maps_flutter] Markers do not obey consumeTapEvents configuration

If you set Marker.consumeTapEvents I would expect the onTap handler not to be called. Currently the event is passed to onTap.

When setting consumeTapEvents to false for Polygons, Polylines, Circles etc. the click handler is not attached to the element, for markers there is no option to disable the click listener in the Google Maps implementation so the result needs to be filtered out in the marker click listener.

Both iOS and Android are affected.

Still reproducible on current version of the maps plugin.

code sample

import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MapsDemo(),
    );
  }
}

class MapsDemo extends StatefulWidget {
  @override
  State createState() => MapsDemoState();
}

class MapsDemoState extends State<MapsDemo> {

  GoogleMapController mapController;
  LatLng _position = LatLng(40.73215972821489, -73.980936957489);
  Set<Marker> markers = {};

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        body: GoogleMap(
          mapToolbarEnabled: false,
          initialCameraPosition: CameraPosition(target: _position, zoom: 15.0),
          cameraTargetBounds: CameraTargetBounds(new LatLngBounds(
              northeast: LatLng(40.73215972821489, -73.980936957489),
              southwest: LatLng(40.7152797683329, -74.01919598687743)
          )
          ),
          markers: markers,
          onTap: (_position) {
            markers.add(Marker(
              markerId: MarkerId('m1'),
              draggable: true,
              position: _position,
              consumeTapEvents: false,
              onTap: () {
                print("Called...");
              },
              icon: BitmapDescriptor.defaultMarkerWithHue(100),
            ));
            mapController.moveCamera(CameraUpdate.newLatLng(_position));
            setState(() {

            });
          },
          onMapCreated: (GoogleMapController controller) {
            mapController = controller;
          },
        ),
    );
  }
}

3d82bdc Revert "Add testing hints (flutter#39868)" (flutter-team-arch…

4aad948 Reland: Add testing hints (flutter#39868) (flutter-team-archi…

Not fixed in the latest version

I believe this is working correctly, but it's just an odd api decision and confusing documentation. There's two tap handlers: the default handler which centers the map on the marker, and there's the user's custom onTap handler. To disable the default handler, set consumeTapEvents to true. To disable the user's handler, set onTap to null.

This works for me on iOS to disable the centering on the marker with a custom tap handler, haven't tested Android.

Navigation Menu

Repository navigation

[google_maps_flutter] Markers do not obey consumeTapEvents configuration #39868

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[google_maps_flutter] Markers do not obey consumeTapEvents configuration #39868

Description

Activity

pedromassangocode commented on Apr 28, 2021

nzkn commented on Aug 1, 2023

nzkn commented on Aug 1, 2023

jaween commented on Sep 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions