Repository navigation
Text selection highlight doesn't reach down to bottom of font (on Android) #4349
Description
(Notice how the highlighting on Android has some padding above and below the text. Looks like Flutter's highlighting doesn't have the same padding.)
Flutter: (notice how the bottoms of the j's aren't covered by the highlight)
Android:
Activity
sethladd commentedon Jun 3, 2016
cc @mpcomplete
abarth commentedon Jun 3, 2016
Related to #4321
Fix text selection painting to draw what the engine tells us. (#4397)
sethladd commentedon Jun 8, 2016
We reach down to the bottom of the text now, but we don't include any bottom padding.
sethladd commentedon Jun 8, 2016
I looked at other iOS apps with text selection. Looks like the highlighting only extends to the bottom of the text, but no bottom padding on iOS:
Since our text selection highlights to the bottom of the word, I think we can close this.
Thanks for the help in tweaking this!
eseidelGoogle commentedon Jun 9, 2016
Selection used to be a very platform specific behavior on the web. We may
end up having to implement different styles between iOS and Android as
well, not sure. Certainly will end up wanting to test on both.
http://stackoverflow.com/questions/18939025/nsattributedstring-highlight-background-color-shows-between-lines-ugly
is an example of someone with a windows background/preference trying to get
the windows (don't fill between lines) effect on Mac (desktop). I'm not
able to find a better comparison, although blogs about this stuff used to
exist somewhere. :D
On Wed, Jun 8, 2016 at 1:29 PM, Seth Ladd [email protected] wrote:
Roll skia to 0658f7 (flutter#4349)
github-actions commentedon Sep 6, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.