Skip to content

Cleanup flutter analyze command defaults. #4387

Closed

Description

@pq

As discussed in #4348, the defaults for flutter analyze would benefit from some (re)consideration.

@Hixie proposes:

Maybe the right behavior is to have everything default off, and if you specify none, we use --current-package?

On the surface this sounds right to me.

@devoncarew ?

Activity

  1. added
    c: new featureNothing broken; request for a new capability
    toolAffects the "flutter" command-line tool. See also t: labels.
    on Jun 6, 2016
  2. added this to the milestone on Jun 6, 2016
  3. devoncarew commented on Jun 6, 2016

    @devoncarew
    Contributor
    Usage: flutter analyze [arguments]
    -h, --help                      Print this usage information.
        --[no-]flutter-repo         Include all the examples and tests from the Flutter repository.
        --[no-]current-directory    Include all the Dart files in the current directory, if any.
                                    (defaults to on)
    
        --[no-]current-package      Include the lib/main.dart file from the current directory, if any.
                                    (defaults to on)
    
        --[no-]dartdocs             List every public member that is lacking documentation (only examines files in the Flutter repository).
        --[no-]preamble             Display the number of files that will be analyzed.
                                    (defaults to on)
    
        --[no-]congratulate         Show output even when there are no errors, warnings, hints, or lints.
                                    (defaults to on)
    
        --watch                     Run analysis continuously, watching the filesystem for changes.
        --[no-]pub                  Whether to run "pub get" before executing this command.
                                    (defaults to on)
    

    I wonder if we could eliminate some of these options entirely, and simplify the matrix of possibilities a bit?

  4. pq commented on Jun 6, 2016

    @pq
    ContributorAuthor
    --[no-]current-directory    Include all the Dart files in the current directory, if any.
                                (defaults to on)
    

    Maybe this can be removed given that we should get the equivalent like so:

    flutter analyze .

    (Bonus points for being shorter than flutter analyze --current-directory 😄 )

  5. modified the milestones: , on Jan 30, 2017
  6. Hixie commented on Jan 30, 2017

    @Hixie
    Contributor

    Closing in favour of #7274

  7. github-actions commented on Sep 5, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: new featureNothing broken; request for a new capabilitytoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions