Fix flutter analyze defaults when files are specified (#4091). - #4348

This won't work because it would make us ignore the arguments if they're explicitly set.

it would make us ignore the arguments if they're explicitly set.

Agreed. I guess I was assuming that was not a common use case. Maybe I'm wrong though. Do you find yourself wanting to analyze a list of files and the current package or directory? I was seeing that as a degenerate case. Or?

@Hixie : added a check to ensure that we only override settings if they are not user-specified. PTAL.

I think I'd move the flutterRepo checks up into the top part as well, so that --current-directory --flutter-repo does both too. (Also maybe the docs should be adjusted to say that the default only applies if nothing else is specified on the command line.)

I agree that this is an edge case, but having this kind of polish throughout the entire project is what leads to people having confidence in the project. Everyone will hit some minor edge case. We have to get all of the edge cases right so that everyone's particular edge case works as they expect.

In any case, LGTM once you're confident you've polished it enough that it shines ;-)

having this kind of polish throughout the entire project is what leads to people having confidence in the project.

👍 I totally agree here.

Otherwise, I'm not totally sure what the desired behavior is WRT to flutter-repo. I think you mean

• flutter analyze --current-directory --flutter-repo
• flutter analyze --current-package --flutter-repo
• flutter analyze --current-directory --current-package --flutter-repo

should analyze the repo, plus the directory, package and both respectively?

Presumably, this should add foo.dart too?

• flutter analyze --current-directory --current-package --flutter-repo foo.dart

I'm inclined to tackle these variations with some tests in a follow-up PR after we clarify what variations we want to support (and how). Might be a good time to revisit the defaults too in the spirit of general polish.

Sound reasonable?

Sound reasonable?

Totally.

Maybe the right behavior is to have everything default off, and if you specify none, we use --current-package?

Cool. Opened #4387 to track command cleanup.