Skip to content

Refactor our viewport logic into a new RenderObject subclass hierarchy #4430

Closed
Closed
Refactor our viewport logic into a new RenderObject subclass hierarchy#4430
Assignees
Hixie
Labels
c: API breakBackwards-incompatible API changesc: performanceRelates to speed or footprint issues (see "perf:" labels)customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.
Milestone
2: Make Early Adopters happy

Description

@Hixie
Hixie
opened on Jun 7, 2016

Rather than use RenderBox for viewports, we should invent a new render object protocol that is used for lazy viewporting and scrolling.

This protocol would have:

  • Inputs: main axis, main axis start offset, main axis end offset, cross-axis dimension
  • Outputs: main axis layout size, main axis offset consumed, paint phase (top, header, content)
  • Intrinsics: In some cases, we will need a way to enable intrinsic dimensions to propagate through (e.g. popup menus), but this is super expensive, so we should have a way to turn it on or off.

Activity

  1. Hixie
    added
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: performanceRelates to speed or footprint issues (see "perf:" labels)
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on Jun 7, 2016
  2. Hixie
    added this to the milestone on Jun 7, 2016
  3. abarth
    self-assigned this
    on Jul 7, 2016

  4. abarth commented on Jul 7, 2016

    @abarth
    abarth
    on Jul 7, 2016
    Contributor

    Started experimenting in https://github.com/abarth/flutter/tree/viewported

  5. abarth commented on Jul 11, 2016

    @abarth
    abarth
    on Jul 11, 2016
    Contributor

    inputs: min/max of start/end offset, main axis, cross axis extent, anchor
    outputs: main axis extent, start/end offset

  6. sethladd
    modified the milestones: August, on Jul 21, 2016
  7. abarth
    assigned
    Hixie
    and unassigned
    abarth
    on Sep 13, 2016
  8. abarth
    added
    c: API breakBackwards-incompatible API changes
    on Sep 13, 2016
  9. Hixie
    removed their assignment
    on Sep 16, 2016

  10. 6 remaining items

  11. Hixie
    modified the milestone: on Sep 16, 2016
  12. Hixie
    added
    f: scrollingViewports, list views, slivers, etc.
    on Sep 23, 2016
  13. Hixie
    assigned
    Hixie
    and unassigned
    Hixie
    on Sep 23, 2016
  14. Hixie
    modified the milestone: 2: Make Early Adopters happy on Dec 21, 2016

  15. abarth commented on Feb 10, 2017

    @abarth
    abarth
    on Feb 10, 2017
    Contributor

    This is now RenderViewport2.

  16. abarth
    closed this as completedon Feb 10, 2017
  17. cdotstout
    added a commit that references this issue on Apr 3, 2018

    [fuchsia] Use AOT in release builds (flutter#4430)

    2e6afc5

  18. github-actions commented on Sep 5, 2021

    @github-actions
    github-actionsbot
    on Sep 5, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  19. github-actions
    locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: API breakBackwards-incompatible API changesc: performanceRelates to speed or footprint issues (see "perf:" labels)customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions