Icon widget (or a new widget) should support giving an icon from another font #4494

Activity

1. Hixie

   added

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   on Jun 9, 2016
2. Hixie

   added this to the Flutter 1.0This milestone has been deleted milestone on Jun 9, 2016
3. Hixie commented on Jun 9, 2016

   

   Hixie

   on Jun 9, 2016

   ContributorAuthor

   More actions

   Maybe they should take a Widget instead of an IconData, and we should make the Icon constructor have the material icons font icon as a positional argument, and we should make the places that current create the Icon to put in instead create an IconTheme to put in.

   Then you could either pass an Icon, or an Image, or whatever.
4. Hixie commented on Jun 9, 2016

   

   Hixie

   on Jun 9, 2016

   ContributorAuthor

   More actions

   We'd probably need to make that an IconImage widget, so that it can take the IconTheme and apply it to the image it wants to show.
5. Hixie

   self-assigned this

   on Jun 21, 2016
6. Hixie

   added

   waiting for PR to land (fixed)A fix is in flightA fix is in flight

   and removed

   waiting for PR to land (fixed)A fix is in flightA fix is in flight

   on Jun 21, 2016
7. Hixie commented on Jun 22, 2016

   

   Hixie

   on Jun 22, 2016

   ContributorAuthor

   More actions

   I fixed the image part of this. Still need to support using another font.

   Maybe IconData should have a font-family field?
8. Hixie

   removed their assignment

   on Jun 22, 2016
9. Hixie

   changed the title [-]Widgets that take icons should have an affordance for giving an Image or an icon from another font[/-] [+]Icon widget (or a new widget) should support giving an icon from another font[/+] on Jan 30, 2017
10. Hixie

    modified the milestones: 4: Make shippers happyThis milestone has been deleted, 5: Make Hixie proudThis milestone has been deleted on Jan 30, 2017
11. abarth

    added a commit that references this issue on Mar 18, 2017

    Adds support for custom fonts for icons

    ...

    This issue will close once commit 0e58913 is merged into the 'master' branch.

    0e58913
12. abarth

    closed this as completedin #8880on Mar 18, 2017
13. abarth

    added a commit that references this issue on Mar 18, 2017

    Adds support for custom fonts for icons (#8880)

    ...

    This issue will close once commit c95e734 is merged into the 'master' branch.

    c95e734
14. cdotstout

    added a commit that references this issue on Apr 3, 2018

    Revert "Ensure language and country codes are not empty" (flutter#4494)

    ea2ce27
15. stuartmorgan-g

    added a commit that references this issue on Apr 30, 2021

    Refactor everything to do with images (flutter#4583)

    ...

    e1bd2aa
16. github-actions commented on Aug 17, 2021

    

    github-actionsbot

    on Aug 17, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
17. github-actions

    locked as resolved and limited conversation to collaborators on Aug 17, 2021