Skip to content

Split the configuration for selecting an image from the configuration of its painting #4500

Closed
#4583
Closed
Split the configuration for selecting an image from the configuration of its painting#4500
#4583
Assignees
Hixie
Labels
c: new featureNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight

Description

@Hixie
Hixie
opened on Jun 9, 2016

Right now, you pick the image using AssetImage or RawImageResource or whatever, and at the same time you specify its dimensions.

This makes it hard for other widgets to accept images in general from any source, but then additionally apply an opinion regarding how the image should be displayed (e.g. dimensions, fit, or repetition).

Proposal: We should instead have a single image-displaying widget, which you configure by passing an object that knows how to get the image (from a context).

e.g. instead of:

   new AssetImage(name: 'foo', width: 24.0)
   new RawImage(image: bar, width: 24.0)
   new NetworImage(src: 'http://baz', width: 24.0)

...have:

   new Image(image: AssetImage('foo'), width: 24.0)
   new Image(image: RawImage(bar), width: 24.0)
   new Image(image: NetworkImage('http://baz'), width: 24.0)

Activity

  1. Hixie
    added
    c: new featureNothing broken; request for a new capability
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Jun 9, 2016
  2. Hixie
    added this to the milestone on Jun 9, 2016
  3. Hixie
    self-assigned this
    on Jun 9, 2016
  4. Hixie
    added
    waiting for PR to land (fixed)A fix is in flight
    on Jun 15, 2016
  5. Hixie
    closed this as completedin #4583on Jun 16, 2016
  6. Hixie
    added a commit that references this issue on Jun 16, 2016

    Refactor everything to do with images (#4583)

    2dfdc84
  7. cdotstout
    added a commit that references this issue on Apr 3, 2018

    Remove mention of update-packages now that we pin them (flutter#4500)

    8ed270e
  8. stuartmorgan-g
    added a commit that references this issue on Apr 30, 2021

    Refactor everything to do with images (flutter#4583)

    e1bd2aa

  9. github-actions commented on Aug 15, 2021

    @github-actions
    github-actionsbot
    on Aug 15, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. github-actions
    locked as resolved and limited conversation to collaborators on Aug 15, 2021
  11. chunhtai
    added a commit that references this issue on Jun 12, 2026

    Refactor everything to do with images (flutter#4583)

    0ca754c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: new featureNothing broken; request for a new capabilityframeworkflutter/packages/flutter repository. See also f: labels.waiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions