Skip to content

Enable access Golden File comparator on LUCI #49837

Closed

Description

@blasten

This is currently a no-op on LUCI since https://github.com/flutter/flutter/blob/master/packages/flutter_goldens/lib/flutter_goldens.dart#L244 returns false on LUCI.

cc @Piinks
Related to #49749

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    team-infraOwned by Infrastructure team
    on Jan 30, 2020
  2. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    on Jan 31, 2020
  3. self-assigned this
    on Jan 31, 2020
  4. added this to the milestone on Feb 3, 2020
  5. lock commented on Apr 4, 2020

    @lock

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked and limited conversation to collaborators on Apr 4, 2020
  7. blasten commented on May 21, 2020

    @blasten
    Author

    @Piinks is this issue fixed by #49815? Is there any test running on LUCI that verifies the fix?

  8. Piinks commented on May 21, 2020

    @Piinks
    Contributor

    @Piinks is this issue fixed by #49815? Is there any test running on LUCI that verifies the fix?

    Yup!
    All pre and post submit luci builds are using Gold for flutter/flutter.

  9. blasten commented on May 21, 2020

    @blasten
    Author

    fantastic. Thanks @Piinks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: tests"flutter test", flutter_test, or one of our testsc: contributor-productivityTeam-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions