Repository navigation
Diagnosticable should be made into a mixin #50498
Description
Activity
- changed the title
[-]Diagnosticable should be remove in favor of DiagnosticableMixin[/-][+]Diagnosticable should be removed in favor of DiagnosticableMixin[/+]on Feb 10, 2020 - changed the title
[-]Diagnosticable should be removed in favor of DiagnosticableMixin[/-][+]Diagnosticable should be made into a mixin[/+]on Feb 26, 2020 The plan now is to remove
DiagnosticableMixineventually, and just keep the mixinDiagnosticable, effectively converting the abstract classDiagnosticableinto a mixin.DiagnosticableMixincan't be removed until the mixin version ofDiagnosticableis available in the stable branch, since some plugins that currently useDiagnosticableMixinwant to be compatible with both stable and master.I believe this has now been in a stable release.
Yes, this is already on my list to do.
- added a commit that references this issue
on Jun 3, 2020 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 19, 2021
Since
Diagnosticableand classes that implementDiagnosticableMixinaren't the same type, code can't compare the type of an object withDiagnosticableto find out if it should calltoDiagnosticsNodeor not. See #49647 for more details.In #49726, I fixed all the instances of this in Flutter where this happens by adding
implements Diagnosticableto all of the mixin classes, but I still need to fix some instances of it in Google internal code before removingDiagnosticableentirely in favor ofDiagnosticableMixin