Repository navigation
Remove DiagnosticableMixin in favor of Diagnosticable - #58635
Merged
fluttergithubbot merged 1 commit intoJun 16, 2020
Merged
Conversation
fluttergithubbot
added
framework
gspencergoog
changed the title
gspencergoog
force-pushed
the
remove_diagnosticable_mixin
branch
from
June 12, 2020 19:33
2c6d2bd to
135a317
Compare
gspencergoog
force-pushed
the
remove_diagnosticable_mixin
branch
from
June 15, 2020 18:35
135a317 to
706804a
Compare
gspencergoog
marked this pull request as ready for review
June 15, 2020 19:22
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gspencergoog
changed the title
zljj0818
pushed a commit
to zljj0818/flutter
that referenced
this pull request
Jun 22, 2020
MarcPerezPro
added a commit
to MarcPerezPro/xd-to-flutter-plugin
that referenced
this pull request
Jun 26, 2020
Due to a breaking change made by flutter/flutter#58635 with flutter 1.20.0 (channel dev at the time of writing), we have to upgrade flutter_svg to 0.18.0.
4 of 10 tasks
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes
DiagnosticableMixin, since it is a duplicate implementation ofDiagnosticable. It existed in order to support plugins that wanted to support both master and stable, but nowDiagnosticableis a mixin on stable, so we don't need it anymore.Related Issues
Breaking Change
DiagnosticableMixin.