Repository navigation
flutter attach doesn't connect after the flutter module's VM/engine started #52975
Description
Tested via https://github.com/flutter/samples/tree/master/add_to_app/android_fullscreen and https://github.com/flutter/samples/tree/master/add_to_app/flutter_module.
Seems to occur both on master and on stable. flutter attach works on Android if started before the Flutter engine / service isolate starts. But after the engine is already running, flutter attach will way for a connection forever.
However, the observatory URL prompt was present in the 'past' logcat
13:43:57.678 30387 30553 I flutter : Observatory listening on http://127.0.0.1:37493/vtV6P-reD5I=/. The tool seems to not be picking it up.
Tested on API 29 and 30. Seems like a bug. We probably need e2e testing for this scenario.
Thanks for the heads up @redbrogdon. cc @blasten.
Activity
xster commentedon Mar 20, 2020
Doing some more testing. It could be a TODAY / cherry pick candidate
jonahwilliams commentedon Mar 20, 2020
Hasn't this always been the case for Android? See the old doc: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/doc/attach.md
xster commentedon Mar 20, 2020
I think that doc should be made obsolete by a combination of #44637 and #45743
blasten commentedon Mar 21, 2020
This is a regression. The problem is that this feature requires at least two kind of device log reader. One that doesn't filter out previous logs and one that does.
xster commentedon Mar 21, 2020
Unusual though that it didn't seem to work on stable either. Wonder if it's due to a change from the android side too.
blasten commentedon Mar 21, 2020
@xster it's probably due to cherrypicking some commits from master into stable.
xster commentedon Mar 21, 2020
Good call @blasten. It was caused by #50488 which was the last commit onto the stable branch.
We should cherry-pick a fix onto stable (and add more tests 🙂).
xster commentedon Mar 21, 2020
Or this one more specifically #45743
xster commentedon Mar 21, 2020
I vaguely remember that conversation now. Did we essentially break flutter attach on tot with #45743 but since we already cut stable, we merged it to fix benchmarks on head and gave us a few weeks to fix it again before the next cut but never came back to it?
zanderso commentedon Mar 24, 2020
@xster @blasten Sorry I'm having a little trouble following the discussion. My understanding is that this is something that might have worked by accident in the past. If that's not correct, do we know how it broke? Is it broken on master or just on stable following the hotfix?
If it never worked on purpose, I'm wondering if this should be marked 'regression' and 'TODAY'.
Thanks!
xster commentedon Mar 24, 2020
The timeline was that it worked on 1.12.13 through hotfix 7. We broke it on master to fix #45732 since stable was already cut but didn't get back to unbreak it in master and the breaking commit got into stable in hotfix 8 as well.
pcsosinski commentedon Mar 24, 2020
xster commentedon Mar 24, 2020
I think it should be limited, since I'm changing flutter attach on Android (where the breakage is). Though I'm happy to let it sit on dev for a week too if needed.
jmagman commentedon Mar 25, 2020
Reopening, #53153 was reverted. flutter_attach_test_android was failing on multiple agents.
flutter_attach_test_android_0c5ffdc_4.log
lock commentedon Apr 26, 2020
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.