Skip to content

Gallery, Pesto: non-fading app bar when opening a recipe #5350

Closed

Description

@sethladd

Open Gallery, open pesto, scroll up enough to minimize the app bar. Tap a recipe.

Notice how the app bar immediately disappears, before the recipe begins its motion up. This is a jarring effect that the user could notice.

We could try something more subtle, like animating or fading the app bar away as the recipe opens?

Activity

  1. added
    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.
    on Aug 11, 2016
  2. added this to the August milestone on Aug 11, 2016
  3. Hixie commented on Aug 11, 2016

    @Hixie
    Contributor

    This is basically #5232

  4. sethladd commented on Aug 11, 2016

    @sethladd
    ContributorAuthor

    (Fixing this issue might also resolve #5351)

  5. sethladd commented on Aug 11, 2016

    @sethladd
    ContributorAuthor

    I believe @HansMuller is taking a look at this.

  6. modified the milestones: , August on Sep 9, 2016
  7. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    on Sep 12, 2016
  8. eseidelGoogle commented on Feb 3, 2017

    @eseidelGoogle
    Contributor

    I'm not sure what I'm looking for here. It looks reasonable?
    transition mov

  9. sethladd commented on Feb 3, 2017

    @sethladd
    ContributorAuthor

    Notice how the app bar immediately disappears, before the recipe begins its motion up. This is a jarring effect that the user could notice.

  10. HansMuller commented on Feb 3, 2017

    @HansMuller
    Contributor

    At the start of the Hero transition the Hero, the recipe image in this case, is moved into the overlay. It was partially behind the appbar, now it's completely on top. It's not entirely clear how to handle this case. It turns out to be difficult for Android native as well: https://plus.google.com/+AlexLockwood/posts/RPtwZ5nNebb

    Do really do this well we'd need to stage the hero transition: first get the appbar out of the way, then do the recipe image hero transition.

    There's probably advice about how to handle this scenario here: https://material-motion.github.io/material-motion/

  11. sethladd commented on Oct 11, 2017

    @sethladd
    ContributorAuthor

    We've hidden Pesto.

  12. github-actions commented on Aug 15, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  13. locked as resolved and limited conversation to collaborators on Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    customer: galleryRelating to flutter/gallery repository. Please transfer non-framework issues there.frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions