Repository navigation
Migrate existing android/settings.gradle to the new file. #54566
Description
android/settings.gradle will be changed after #54407 is merged:
include ':app'
-def flutterProjectRoot = rootProject.projectDir.parentFile.toPath()
+def localPropertiesFile = new File(rootProject.projectDir, "local.properties")
+def properties = new Properties()
-def plugins = new Properties()
-def pluginsFile = new File(flutterProjectRoot.toFile(), '.flutter-plugins')
-if (pluginsFile.exists()) {
- pluginsFile.withReader('UTF-8') { reader -> plugins.load(reader) }
-}
+assert localPropertiesFile.exists()
+localPropertiesFile.withReader("UTF-8") { reader -> properties.load(reader) }
-plugins.each { name, path ->
- def pluginDirectory = flutterProjectRoot.resolve(path).resolve('android').toFile()
- include ":$name"
- project(":$name").projectDir = pluginDirectory
-}
+def flutterSdkPath = properties.getProperty("flutter.sdk")
+assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
+apply from: "$flutterSdkPath/packages/flutter_tools/gradle/app_plugin_loader.gradle"This could be handled by flutter migrate in #40460.
Activity
Gustl22 commentedon Oct 27, 2023
As migration by the tool is not planned we might need to upgrade it manually by prompting the user: https://github.com/Gustl22/flutter/tree/54566-settings-gradle-migration
It also would make sense to propose upgrading directly to #135392
Gustl22 commentedon Dec 21, 2023
This issue may is obsolete due to #135392 which covers this case. I doubt someone will implement another migration (than the manual docs), if we also don't plan to do this for more recent versions of
settings.gradle.jmagman commentedon Dec 21, 2023
@reidbaker can this be closed then?
bartekpacia commentedon Jan 9, 2024
I agree with @Gustl22, writing a migration tool to automatically migrate
.gradlefiles in infeasible since these files basically contain executable code.Such a tool would only work for the most basic apps that didn't edit their Android buildfiles.
github-actions commentedon Jan 24, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.