add spacing parameter to Column and Row #55378

Activity

1. VladyslavBondarenko commented on Apr 23, 2020

   

   VladyslavBondarenko

   on Apr 23, 2020

   More actions

   Hi @lukepighetti
   Does this workaround suit to you #16957 (comment)?
   Do you have some case where it's not applicable?
2. VladyslavBondarenko

   added

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Apr 23, 2020
3. lukepighetti commented on Apr 23, 2020

   

   lukepighetti

   on Apr 23, 2020

   ContributorAuthor

   More actions

   This is how we currently doing it, I'm asking to unify the spacing API across Wrap, Column, Row. This isn't a question of if there is another solution, it's a question of providing more unified "color" to the commonly used layout APIs.
4. no-response

   removed

   waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter respondsThe Flutter team cannot make further progress on this issue until the original reporter responds

   on Apr 23, 2020
5. VladyslavBondarenko

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   on Apr 23, 2020
6. danagbemava-nc

   added

   passed first triage

   on Dec 14, 2021
7. henry2man commented on Mar 31, 2022

   

   henry2man

   on Mar 31, 2022

   More actions

   Inspired in other solutions & workarounds I've published this gist that adds support for this FR: https://gist.github.com/henry2man/28595050f09633e16641d5f30f1a32ae
8. lukepighetti

   changed the title [-]add runSpacing to Column and spacing to Row[/-] [+]add spacing parameter to Column and Row[/+] on Mar 31, 2022
9. goderbauer

   added

   P6

   on Aug 30, 2022
10. flutter-triage-bot

    added

    P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

    and removed

    P6

    on Jun 28, 2023
11. flutter-triage-bot

    added

    team-frameworkOwned by Framework teamOwned by Framework team

    triaged-frameworkTriaged by Framework teamTriaged by Framework team

    on Jul 8, 2023
12. 104 remaining items

    Load more

13. Piinks commented on Aug 5, 2024

    

    Piinks

    on Aug 5, 2024

    Contributor

    More actions

    Reopening since the change was reverted, just need to address a failing integration test to resolve and get it back in. 👍
14. Piinks

    reopened this on Aug 5, 2024
15. github-project-automation

    moved this from Done (PR merged) to In progress in Nevercodeon Aug 5, 2024
16. TahaTesser

    removed

    r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

    on Aug 5, 2024
17. auto-submit

    closed this as completedin #152890on Aug 5, 2024
18. auto-submit

    added a commit that references this issue on Aug 5, 2024

    [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Colum…

    ...

    00ef750
19. github-project-automation

    moved this from In progress to Done (PR merged) in Nevercodeon Aug 5, 2024
20. TahaTesser

    added

    r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

    on Aug 5, 2024
21. TytaniumDev

    added 3 commits that reference this issue on Aug 7, 2024

    Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (

    ...

    d0ef46d

    Reverts "Introduce `double` `Flex.spacing` parameter for `Row`/`Colum…

    ...

    6e6e72b

    [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Colum…

    ...

    3cf446c
22. SupposedlySam commented on Aug 13, 2024

    

    SupposedlySam

    on Aug 13, 2024

    More actions

    I really appreciate all the discussion here and am looking forward to using it when it's released in stable!

    After reading all the comments though, I couldn't figure out what the reason was that it finally got included in the framework as a property on both Row and Column.

    Would someone kindly recap what the reasons were that ultimately allowed this feature to be introduced?

    I think the PR is very elegant and also caught clipBehavior not being added to the debugFillProperties 👏 Well done @TahaTesser.

    It looks like this comment from @Hixie might be the reason: #152472 (comment)

    ❤️React with ❤️1Reacted by Taha Tesser
23. bernaferrari commented on Aug 13, 2024

    

    bernaferrari

    on Aug 13, 2024

    Contributor

    More actions

    Seems to be "too much people want this" with "the change is actually super small" with "it is super useful" with "I don't think there is a better way" with "we wish we could rewrite Row entirely but we can't".

    👍React with 👍3Reacted by Nate Wilson, Tobias Marschall and Casey Rogers

    ❤️React with ❤️1Reacted by Jonah Walker
24. github-actions commented on Aug 27, 2024

    

    github-actionsbot

    on Aug 27, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
25. github-actions

    locked as resolved and limited conversation to collaborators on Aug 27, 2024