app_flutter test in customer_testing is blocking the engine roll #65041

Activity

1. flar

   added

   team-infraOwned by Infrastructure teamOwned by Infrastructure team

   on Sep 1, 2020
2. flar commented on Sep 1, 2020

   

   flar

   on Sep 1, 2020

   ContributorAuthor

   More actions

   Tagging @jason-simmons @christopherfujino who were involved in the discussion.
3. flar

   added

   P0Critical issues such as a build break or regressionCritical issues such as a build break or regression

   on Sep 1, 2020
4. flar commented on Sep 1, 2020

   

   flar

   on Sep 1, 2020

   ContributorAuthor

   More actions

   There is now discussion about whether dartfmt should have rejected this file in the first place. The line was more than 80 characters, but dartfmt is run with a requested line length of 120, so it shouldn't have required reformatting.

   This may be a bug in the dartfmt command in the latest Dart roll.
5. flar commented on Sep 1, 2020

   

   flar

   on Sep 1, 2020

   ContributorAuthor

   More actions

   As mentioned in the PR, the change to the way that dartfmt wants to format nested conditional expressions was intentional, so this is not a bug.

   There is also a potential formatting that would make both versions of dartfmt happy so we can avoid the chicken and egg issue of which Dart version is running a given Cocoon instance.
6. keyonghan

   changed the title [-]Formatting of progress_button.dart is blocking the engine roll[/-] [+]app_flutter test in customer_testing is blocking the engine roll[/+] on Sep 1, 2020
7. keyonghan commented on Sep 1, 2020

   

   keyonghan

   on Sep 1, 2020

   Last edited by keyonghan

   Contributor

   More actions

   Formatting issue has been fixed by flutter/cocoon#931.

   Now the roll is still blocked by flutter analyze.

   info • This method overrides a method annotated as '@mustCallSuper' in 'RenderObjectElement', but doesn't invoke the overridden method • lib/widgets/lattice.dart:280:8 • must_call_super
      info • This method overrides a method annotated as '@mustCallSuper' in 'RenderObjectElement', but doesn't invoke the overridden method • lib/widgets/lattice.dart:285:8 • must_call_super
      info • This method overrides a method annotated as '@mustCallSuper' in 'RenderObjectElement', but doesn't invoke the overridden method • lib/widgets/lattice.dart:290:8 • must_call_super
   

   Here is a potential fix by @christopherfujino : flutter/tests#49
8. keyonghan commented on Sep 2, 2020

   

   keyonghan

   on Sep 2, 2020

   Contributor

   More actions

   Fix has been submitted. Closing.
9. keyonghan

   closed this as completedon Sep 2, 2020
10. github-actions commented on Aug 13, 2021

    

    github-actionsbot

    on Aug 13, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
11. github-actions

    locked as resolved and limited conversation to collaborators on Aug 13, 2021
12. keyonghan

    moved this to Done in [DEPRECATED] Infra Ticket Queueon May 1, 2023
13. keyonghan

    added this to [DEPRECATED] Infra Ticket Queueon May 1, 2023
14. ricardoamador

    moved this from Verified to To be archived in [DEPRECATED] Infra Ticket Queueon Jun 26, 2023