[doctor] Add macOS architecture to doctor output #65976

Activity

1. gaaclarke

   added

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   t: flutter doctorProblem related to the "flutter doctor" toolProblem related to the "flutter doctor" tool

   on Sep 16, 2020
2. jmagman commented on Sep 16, 2020

   

   jmagman

   on Sep 16, 2020

   Member

   More actions

   It's already there (darwin-x64) in doctor and devices:

   macOS (desktop)        • macos                                    • darwin-x64     • Mac OS X 10.15.5 19F101
   
3. jmagman commented on Sep 16, 2020

   

   jmagman

   on Sep 16, 2020

   Member

   More actions

   It's already there (darwin-x64) in doctor and devices:

   Never mind, that's hardcoded.
   

   flutter/packages/flutter_tools/lib/src/macos/macos_device.dart

   Line 44 in 9f04086

   Future<TargetPlatform> get targetPlatform async => TargetPlatform.darwin_x64;
4. jonahwilliams commented on Sep 16, 2020

   

   jonahwilliams

   on Sep 16, 2020

   Contributor

   More actions

   We print darwin-x64 for every mac though @jmagman , we need to fix that too
5. darshankawar

   added

   passed first triage

   on Sep 22, 2020
6. jmagman

   added

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on Sep 24, 2020
7. jmagman commented on Oct 1, 2020

   

   jmagman

   on Oct 1, 2020

   Last edited by jmagman

   Member

   More actions

   uname -m is reporting x86_64 when forked from a dart process, even on ARM (I stepped into it and checked the output from #65978), so flutter doctor is still showing x86. I don't know how we can get around that until dart is un-rosettafied.

   [✓] Flutter (Channel master, 1.22.0-10.0.pre.448, on macOS 11.0 20A5299w x86_64, locale en-US)
   

   $ uname -m
   arm64
   
8. gaaclarke commented on Oct 1, 2020

   

   gaaclarke

   on Oct 1, 2020

   MemberAuthor

   More actions

   @jmagman That's weird since uname is it's own process I wouldn't have expected the parent to make any difference. You might try changing these parameters to Process.start -- bool includeParentEnvironment, bool runInShell
   https://api.dart.dev/stable/2.10.0/dart-io/Process-class.html

   It's possible uname is just grabbing from an environment variable and since includeParentEnvironment is true it grabs the wrong one.
9. jmagman commented on Oct 27, 2020

   

   jmagman

   on Oct 27, 2020

   Member

   More actions

   As of #67970 this is done for the host in the [✓] Flutter (Channel master line.
   The rest of the work is to track showing it for macOS device targets.
10. fluttergithubbot

    closed this as completedin #69245on Oct 30, 2020
11. github-actions commented on Aug 10, 2021

    

    github-actionsbot

    on Aug 10, 2021

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
12. github-actions

    locked as resolved and limited conversation to collaborators on Aug 10, 2021