Repository navigation
Show macOS arm64 architecture in doctor and devices list - #69245
Merged
Merged
Conversation
flutter-dashboard
Bot
added
the
tool
christopherfujino
approved these changes
Oct 29, 2020
christopherfujino
left a comment
christopherfujino
left a comment
Contributor
There was a problem hiding this comment.
LGTM: with a nit question
jmagman
force-pushed
the
target-arm-mac
branch
from
October 29, 2020 20:56
25f5818 to
86395a3
Compare
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
targetPlatformDisplayNameforflutter doctorandflutter devicesto show when the host is an Apple Silicon macOS ARM machine.Do not add a more substantive
TargetPlatform.darwin_arm64change since the artifacts, build system, etc all requiredarwin_x64even on ARM to leverage Rosetta translation.Related Issues
Fixes #65976
Tests
macos_device_tests