Skip to content

engine gn updates required for simulator on macOS arm #66926

Closed

Description

@jonahwilliams
  • Currently the engine simulator target hardcodes an x64 architecture. This needs to be changed to allow a configurable target CPU (https://github.com/flutter/engine/blob/master/tools/gn#L163).
  • This will also require the existing chrome infra recipes to be updated to specify an x64 arch.
  • Finally, the target arch needs to be included in either the output folder or bundle path, so that the tool can select the appropriate version.

Blocked by #66925
Blocked by #65901

Activity

  1. added
    platform-iosiOS applications specifically
    engineflutter/engine related. See also e: labels.
    on Sep 29, 2020
  2. jmagman commented on Sep 29, 2020

    @jmagman
    Member
    • Finally, the target arch needs to be included in either the output folder or bundle path, so that the tool can select the appropriate version.

    Or, we can do #60109. That will create one bundle with all the architectures (layout details at #36204 (comment)), and Xcode will know how to link on the right pieces.

  3. jonahwilliams commented on Sep 29, 2020

    @jonahwilliams
    ContributorAuthor

    That sounds like it would simplify distribution. The output folder still needs to be changed so the builds don't clobber eachother on the build bots

  4. jmagman commented on Sep 29, 2020

    @jmagman
    Member

    That sounds like it would simplify distribution. The output folder still needs to be changed so the builds don't clobber eachother on the build bots

    Ah, you're right. Plus, to build an xcframework you need all the individual frameworks, then you run a command that smooshes them all together.

  5. added
    P1High-priority issues at the top of the work list
    on Oct 12, 2020
  6. jeco1996 commented on Jan 23, 2021

    @jeco1996

    any ETA?

  7. jmagman commented on Jan 29, 2021

    @jmagman
    Member

    I believe @gw280 tracked down relevant issues and was able to land flutter-team-archive/buildroot#422.

  8. jmagman commented on Jan 29, 2021

    @jmagman
    Member

    Next step is #73066.

  9. github-actions commented on Aug 6, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  10. locked as resolved and limited conversation to collaborators on Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work listc: new featureNothing broken; request for a new capabilityengineflutter/engine related. See also e: labels.platform-iosiOS applications specifically

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions