Repository navigation
sky.ColorFilter needs operator== #69
Description
Activity
Comment by Hixie
Thursday Jul 16, 2015 at 22:25 GMT
From @eseidel on July 16, 2015 4:19
Would be nice to be able to catch these errors in some way. In obj-c one could override -[NSObject equals:] to warn using a "category". I know dart doesn't have those, but maybe there is another solution we should use.
- added this to the milestone
on Nov 9, 2015 Comment by abarth
Monday Oct 26, 2015 at 05:24 GMT
That's right. The steps are:
- Start using the new binding system for
window, replacingview. - Switch the
Canvasinterface over to the new bindings system. - Lift
Paint-related classes up into Dart using the new bindings system.
- Start using the new binding system for
It looks like ColorFilter is still a wrapped native:
https://github.com/flutter/engine/blob/master/sky/engine/core/painting/ColorFilter.hFixed!
- added a commit that references this issue
on Mar 21, 2019 This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Aug 17, 2021
Thursday Jul 16, 2015 at 22:25 GMT
Originally opened as https://github.com/flutter/engine/issues/25
From @abarth on July 15, 2015 19:7
When someone sets a sky.ColorFilter on either a ColorFilter widget or on an Image widget, we call operator== to check whether the filter has changed. If it has changed, we mark ourselves as needing paint. However, sky.ColorFilter doesn't implement operator==, which means we're just getting object identity, which means we're invalidating paint more often than necessary.
/cc @mpcomplete
Copied from original issue: domokit/mojo#324