Asset variant detection should only work on directory names that are parse-able by the framework (2x, 3x) #69388

Activity

1. yash1200 commented on Oct 30, 2020

   

   yash1200

   on Oct 30, 2020

   Last edited by yash1200

   Contributor

   More actions

   Changing your assets list to this :

   final List<String> assets = <String>[
     'placeholder.png',
     'something/placeholder.png',
   ];
   

   and pubspec.yaml to this :

   flutter:
     uses-material-design: true
     assets:
       - assets/
   

   These changes fixed your issue.
2. AlexV525 commented on Oct 30, 2020

   

   AlexV525

   on Oct 30, 2020

   Last edited by AlexV525

   MemberAuthor

   More actions

   @yash1200 That's weird. Since when we could use undeclared assets? Doc ref:https://flutter.dev/docs/development/ui/assets-and-images#specifying-assets

   And why an asset without full path can be used?
3. yash1200 commented on Oct 30, 2020

   

   yash1200

   on Oct 30, 2020

   Contributor

   More actions

   I just experimented and it worked with this.
   Here's a screenshot:

   
4. pedromassangocode

   added

   a: assetsPackaging, accessing, or using assetsPackaging, accessing, or using assets

   found in release: 1.23Found to occur in 1.23Found to occur in 1.23

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work on

   on Oct 30, 2020
5. pedromassangocode commented on Oct 30, 2020

   

   pedromassangocode

   on Oct 30, 2020

   More actions

   I was able to reproduce however not sure if the implementation is the correct one.
6. AlexV525 commented on Oct 30, 2020

   

   AlexV525

   on Oct 30, 2020

   MemberAuthor

   More actions

   I just experimented and it worked with this.

   Thanks for the quick clarify! So there must be something broken with assets loading.
7. AlexV525 commented on Oct 30, 2020

   

   AlexV525

   on Oct 30, 2020

   MemberAuthor

   More actions

   cc @jonahwilliams
8. AlexV525

   added

   P2

   on Oct 30, 2020
9. pedromassangocode commented on Oct 30, 2020

   

   pedromassangocode

   on Oct 30, 2020

   More actions

   Maybe P3 since this is not blocking any customer?
   Feel free to increase the priority if necessary.

   👍React with 👍2Reacted by Alex Li and Yash Johri
10. pedromassangocode

    added

    P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

    and removed

    P2

    on Oct 30, 2020
11. jonahwilliams commented on Oct 30, 2020

    

    jonahwilliams

    on Oct 30, 2020

    Contributor

    More actions

    This is mostly an intention feature - asset variants. The idea is that you can automatically pick up multiple resolutions of the same image and have the framework select them at runtime.

    a.png
    2x/a.png
    3x/a.png
    

    Of course, it is not actually restricted to 2x, 3x as you've discovered here....
12. jonahwilliams

    added

    P2Important issues not at the top of the work listImportant issues not at the top of the work list

    and removed

    P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

    on Oct 30, 2020
13. AlexV525 commented on Oct 30, 2020

    

    AlexV525

    on Oct 30, 2020

    MemberAuthor

    More actions

    Of course, it is not actually restricted to 2x, 3x as you've discovered here....

    When it comes to production cases, assets like the demo in my test app, such as separate placeholder can cause confusing behaviors.

    And what about the solution that @yash1200 suggested?
14. jonahwilliams commented on Oct 30, 2020

    

    jonahwilliams

    on Oct 30, 2020

    Contributor

    More actions

    I think the right fix would to restrict the asset variant code to strings that the framework can parse

    👍React with 👍3Reacted by Alex Li, Yash Johri and Pedro Massango
15. jonahwilliams

    added

    toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

    and removed

    frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

    on Oct 30, 2020
16. jonahwilliams

    changed the title [-]Wrong display when using same name but not the same path assets[/-] [+]Asset variant detection should only work on directory names that are parse-able by the framework (2x, 3x)[/+] on Oct 30, 2020
17. christopherfujino

    added this to go/flutter-tools-project (deprecated)on Jul 11, 2022
18. christopherfujino

    moved this to Good starter bugs/improvements in go/flutter-tools-project (deprecated)on Jul 11, 2022
19. christopherfujino commented on Aug 1, 2022

    

    christopherfujino

    on Aug 1, 2022

    Contributor

    More actions

    cc @eliasyishak
20. jonahwilliams commented on Aug 10, 2022

    

    jonahwilliams

    on Aug 10, 2022

    Contributor

    More actions

    I think this one might be an interesting first issue for @andrewkolos , if you haven't already looked at it @eliasyishak .

    👍React with 👍2Reacted by Christopher Fujino and Elias Yishak

    👀React with 👀1Reacted by Andrew Kolos
21. christopherfujino

    assigned

    andrewkolos

    on Sep 20, 2022
22. auto-submit

    closed this as completedin #110721on Sep 27, 2022
23. github-actions commented on Oct 11, 2022

    

    github-actionsbot

    on Oct 11, 2022

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
24. github-actions

    locked as resolved and limited conversation to collaborators on Oct 11, 2022