Skip to content

Many of our components draw outside their paintBounds #71

Closed

Description

@FlutterIssues

Issue by Hixie
Thursday Jul 16, 2015 at 22:25 GMT
Originally opened as https://github.com/flutter/engine/issues/26


From @Hixie on July 14, 2015 17:22

You can now easily tell what components paint outside their bounds by turning on debugPaintBoundsEnabled in sdk/lib/base/debug.dart. I noticed at least the following in the stocks app:

  • radio buttons
  • switches
  • anything with shadows, including drawer, popup menu, toolbar, floating action button, dialog
  • circles in the stock row

/cc @collinjackson @iansf

Copied from original issue: domokit/mojo#321

Activity

  1. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by Hixie
    Wednesday Oct 28, 2015 at 02:23 GMT


    @abarth Any update on whether we are going to drop the paintBounds concept?

  2. FlutterIssues commented on Nov 9, 2015

    @FlutterIssues
    Author

    Comment by abarth
    Wednesday Oct 28, 2015 at 02:59 GMT


    We can remove paintBounds. There's some chance we'll need it later, but if that happens we can add it back. We should still make most things paint in bounds so they'll hit test and clip correctly.

  3. eseidelGoogle commented on Nov 16, 2015

    @eseidelGoogle
    Contributor

    Sounds like we can close this?

  4. abarth commented on Nov 16, 2015

    @abarth
    Contributor

    Sure, but we should file a code health bug to remove paintBounds from the system.

  5. Hixie commented on Nov 16, 2015

    @Hixie
    Contributor

    And we should probably still verify that the widgets (switch in particular) stay within their bounds. Right now a number of them overflow.

  6. github-actions commented on Sep 7, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. locked as resolved and limited conversation to collaborators on Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions