Skip to content

Broken links on website #7306

Closed
Closed
Broken links on website#7306

Description

@eseidelGoogle
eseidelGoogle
opened on Dec 23, 2016

Links to FlutterViewController.h are broken for example.

A more sustainable fix is probably some sort of automated way to check these as part of publishing. :(

Activity

  1. eseidelGoogle
    added
    affects: website
    ⚠ clear documentation
    on Dec 23, 2016

  2. abarth commented on Dec 23, 2016

    @abarth
    abarth
    on Dec 23, 2016
    Contributor

    There are many things about that page that are out of date.

  3. mit-mit commented on Dec 29, 2016

    @mit-mit
    mit-mit
    on Dec 29, 2016
    Member

    We can configure automated link checking with html proofer and travis. I can do that as soon as we get the links fixed.

    Here are the current issues html proofer reports in platform-services:

    - _site/platform-services/index.html
  *  External link https://docs.flutter.io/flutter/services/MojoShell-class.html failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/android/io/flutter/view/FlutterView.java failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/ios/framework/Headers/FlutterAsyncMessageListener.h failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/ios/framework/Headers/FlutterMessageListener.h failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/ios/framework/Headers/FlutterViewController.h failed: 404 No error
  *  External link https://github.com/flutter/flutter/blob/master/examples/hello_services/ios/HelloServices/AppDelegate.m failed: 404 No error
  *  External link https://github.com/flutter/flutter/blob/master/examples/hello_services/ios/HelloServices/LocationProvider.m failed: 404 No error
  *  External link https://github.com/flutter/flutter/tree/master/examples/hello_services/ios/HelloServices failed: 404 No error

  4. mit-mit commented on Dec 29, 2016

    @mit-mit
    mit-mit
    on Dec 29, 2016
    Member

    Making this bug slightly more general to cover the remaining 18 link issues:

    - _site/animations/index.html
  *  External link https://docs.flutter.io/flutter/physics/ScrollSimulation-class.html failed: 404 No error
- _site/assets-and-images/index.html
  *  External link https://docs.flutter.io/flutter/services/ImageResource-class.html failed: 404 No error
  *  External link https://docs.flutter.io/flutter/widgets/AssetVendor-class.html failed: 404 No error
  *  External link https://github.com/flutter/flutter/tree/master/examples/widgets failed: 404 No error
- _site/debugging/index.html
  *  External link https://docs.flutter.io/flutter/material/InkFeatures-class.html failed: 404 No error
  *  External link https://docs.flutter.io/flutter/rendering/RenderObject/debugDescribeSettings.html failed: 404 No error
  *  External link https://docs.flutter.io/flutter/scheduler/Scheduler/addPersistentFrameCallback.html failed: 404 No error
- _site/platform-services/index.html
  *  External link https://docs.flutter.io/flutter/services/MojoShell-class.html failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/android/io/flutter/view/FlutterView.java failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/ios/framework/Headers/FlutterAsyncMessageListener.h failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/ios/framework/Headers/FlutterMessageListener.h failed: 404 No error
  *  External link https://github.com/flutter/engine/blob/master/sky/shell/platform/ios/framework/Headers/FlutterViewController.h failed: 404 No error
  *  External link https://github.com/flutter/flutter/blob/master/examples/hello_services/ios/HelloServices/AppDelegate.m failed: 404 No error
  *  External link https://github.com/flutter/flutter/blob/master/examples/hello_services/ios/HelloServices/LocationProvider.m failed: 404 No error
  *  External link https://github.com/flutter/flutter/tree/master/examples/hello_services/ios/HelloServices failed: 404 No error
- _site/rendering/index.html
  *  internally linking to ../../example/rendering/sector_layout.dart, which does not exist (line 577)
     <a href="../../example/rendering/sector_layout.dart">sector_layout.dart
example</a>
- _site/text-input/index.html
  *  External link https://docs.flutter.io/flutter/widgets/RawInputLine-class.html failed: 404 No error
- _site/widgets-intro/index.html
  *  External link https://docs.flutter.io/flutter/material/InputState-class.html failed: 404 No error
htmlproofer 3.4.0 | Error:  HTML-Proofer found 18 failures!
  5. mit-mit
    changed the title [-]Broken links in https://flutter.io/platform-services/[/-] [+]Broken links on website[/+] on Dec 29, 2016
  6. mit-mit
    added a commit that references this issue on Dec 29, 2016

    Fix a few broken links

    9054d2c

  7. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    It seems our getting started instructions for website development need some work:
    https://github.com/flutter/website/blob/master/README.md

    I was able to install some of the various necessary ruby/jekyll/gems bits, but at least one of the gems (gem install yajl-ruby -v '1.2.1') won't compile on Mac 10.11.6, presumably it's pulled in due to our ancient version of jeckyll?

  8. mit-mit commented on Dec 29, 2016

    @mit-mit
    mit-mit
    on Dec 29, 2016
    Member

    We should be using bundler; then the instructions should be as easy as:

    sudo gem install bundler
bundle install
bundle exec jekyll serve

    Can you see if that works for you?

  9. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    https://gist.github.com/eseidelGoogle/5b629b9056fb4c1511bd34d0f4b70c36

  10. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    Looks like the issue was fixed in yajl-ruby 1.3.0: brianmario/yajl-ruby#165

  11. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    I can try downgrading my ruby from 2.4.0, I had to upgrade due to something else not being compatible with 2.0.0

  12. mit-mit commented on Dec 29, 2016

    @mit-mit
    mit-mit
    on Dec 29, 2016
    Member

    OK, that might be it, I'm on 2.3:

    $ ruby --version
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]

  13. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    Attempting to manually force yajl-ruby 1.30 I got:

    Bundler could not find compatible versions for gem "yajl-ruby":
  In Gemfile:
    yajl-ruby (= 1.3.0)

    jekyll (= 2.4.0) was resolved to 2.4.0, which depends on
      pygments.rb (~> 0.6.0) was resolved to 0.6.3, which depends on
        yajl-ruby (~> 1.2.0)

  14. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    2.0 is default on el capitan:
    eseidel@eseidel-macbookpro /src/website %ruby -v [/src/website]
    ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin15]
    eseidel@eseidel-macbookpro /src/website %which ruby [/src/website]
    /usr/bin/ruby

    And 2.4 is available from brew. Looks like the way you get 2.3 on mac is via rbenv:
    https://gorails.com/setup/osx/10.11-el-capitan

  15. eseidelGoogle commented on Dec 29, 2016

    @eseidelGoogle
    eseidelGoogle
    on Dec 29, 2016
    ContributorAuthor

    @mit-mit I now have a working setup. Could you paste the commands you're using to htmlproofer to get the errors? I tried htmlproofer ._site/ and a few other variants and didn't get the same set of errors you're seeing.

  16. mit-mit commented on Dec 29, 2016

    @mit-mit
    mit-mit
    on Dec 29, 2016
    Member

    Sure thing, see the PR: https://github.com/flutter/website/pull/340/files#diff-04c6e90faac2675aa89e2176d2eec7d8

  17. mit-mit
    added a commit that references this issue on Jan 5, 2017

    Fix a few broken links (#341)

    a50af70

  18. sethladd commented on Feb 8, 2017

    @sethladd
    sethladd
    on Feb 8, 2017
    Contributor

    I think we did this, yes? Closing. Please reopen if we have more work planned.

  19. sethladd
    closed this as completedon Feb 8, 2017
  20. amirh
    added 2 commits that reference this issue on Dec 28, 2018

    Roll engine to f0a1d6f

    7845274

    Roll engine to f0a1d6f (#25849)

    63b2daf
  21. kangwang1988
    added a commit that references this issue on Feb 12, 2019

    Roll engine to f0a1d6f (flutter#25849)

    d329a9c

  22. github-actions commented on Sep 5, 2021

    @github-actions
    github-actionsbot
    on Sep 5, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  23. github-actions
    locked as resolved and limited conversation to collaborators on Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions