Repository navigation
Fix a few broken links - #341
Conversation
As discussed in flutter/flutter#7306 and #340
googlebot
added
the
cla: yes
| If you're using IntelliJ, you can also debug your application using its | ||
| built-in debugger. | ||
| If you started your application on an Android device using `flutter run`, then, | ||
| while it is running, you can open the Web page at `http://localhost:8181/` to |
There was a problem hiding this comment.
We should replace this with "...then, while it is running, you can open the Web page at the address given by the flutter run tool to connect..." because the URL changes every time now.
| <div class="box2"> | ||
| <figure> | ||
| <img src="/images/flutter-starter-app-ios.png"> | ||
| <img src="/images/flutter-starter-app-ios.png" alt="iOS screenshot"> |
There was a problem hiding this comment.
that is not a valid alt value. It is more correct to omit the alt attribute here.
There was a problem hiding this comment.
See https://html.spec.whatwg.org/#alt for detailed information on what the alt attribute value should be.
There was a problem hiding this comment.
https://html.spec.whatwg.org/#a-key-part-of-the-content in particular has examples of screen shot alt texts
There was a problem hiding this comment.
Yes, those were not great alt strings.
I don't think omitting the attribute would be correct. From the spec you linked, that is only correct when the image contents are not known.
Rather, in this case the image is not a key part of the content, but rather merely a graphical representation of the surrounding text, so they can be left empty per §4.8.4.4.6.
| <div class="box2"> | ||
| <figure> | ||
| <img src="/images/flutter-starter-app-android.png"> | ||
| <img src="/images/flutter-starter-app-android.png" alt="Android screenshot"> |
These images are merely a graphical representation of the surrounding text, so they can be left empty per §4.8.4.4.6: https://html.spec.whatwg.org/#a-graphical-representation-of-some-of-the-surrounding-text
|
Thanks for the feedback, updated |
|
@Hixie any more comments, or can I get a LGTM? |
|
LGTM. |
3 participants
As discussed in flutter/flutter#7306 and #340