Repository navigation
test_runner is truncating builder name on mac #76582
Description
Mac_ios builders are truncating the builderName and trying to find tasks with builder Mac_ios:
{{ message }}
Mac_ios builders are truncating the builderName and trying to find tasks with builder Mac_ios:
Activity
CaseyHillers commentedon Feb 23, 2021
CL: https://flutter-review.googlesource.com/c/recipes/+/10720
CaseyHillers commentedon Feb 23, 2021
Recipes are fine. LUCI handles escaping the spaces in the command line args.
Example run with spaces:
runner.sh -t flutter_gallery_ios__compile --results-file results.json --luci-builder 'Mac_ios flutter_gallery_ios__compile' --git-branch masterThe issue is in how the upload metrics request is being constructed that is causing Cocoon to drop everything after the space.
godofredoc commentedon Feb 23, 2021
I believe the problem is in the call to dart runner inside runner.sh as $* is translated as a string without quotes which makes the parser to treat every word as a separate argument. Linux seems to deal correctly with the params but mac is not:
https://cs.opensource.google/flutter/recipes/+/master:recipes/devicelab/devicelab_drone.resources/runner.sh;l=13
CaseyHillers commentedon Feb 23, 2021
I did a local run on my mac with the command LUCI is using on mac (see #76582 (comment)). Everything goes as expected until the request to Cocoon. AppEngine is expecting the spaces to be url encoded to %20, which isn't happening.
godofredoc commentedon Feb 23, 2021
Results file already has the task name truncated:
https://chromium-swarm.appspot.com/task?id=51e93e455e636c10
Please take a look at the present result file - result output at the end
[-]test_runner is truncating builder name[/-][+]test_runner is truncating builder name on mac[/+]CaseyHillers commentedon Feb 23, 2021
Thanks Godofredo. To recap, the issue seems to only occur on the mac builders, so it's possibly related to the runner.sh logic and how LUCI forwards the runner params to the script.
CaseyHillers commentedon Feb 24, 2021
@godofredoc added a fix in the mac runner script for this: https://flutter-review.googlesource.com/c/recipes/+/10742
Thank you!
github-actions commentedon Aug 5, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.