Skip to content

CupertinoSliverNavigationBar and CupertinoNavigationBar should support background colors #78607

Closed
Closed
CupertinoSliverNavigationBar and CupertinoNavigationBar should support background colors#78607
Labels
P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages teamwaiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds

Description

@campovski
campovski
opened on Mar 19, 2021

Both CupertinoSliverNavigationBar and CupertinoNavigationBar should support background colors for the expanded and collapsed states. These colors could also be lerped when those states are in transition.

The second part of the original issue should be followed up on in #53788

OP:

Use case

Currently, CupertinoSliverNavigationBar does not support the following two things.

  1. Different background colors for expanded and collapsed state.
  2. Different titles for expanded and collapsed state. The use case could be using largeTitle: 'Profile' and middle: username for example. Currently, in expanded state both largeTitle and middle are shown, which I think is incorrect.

Proposal

I propose that CupertinoSliverNavigationBar supports the following two things:

  1. different background colors for expanded and collapsed state with possibility to animate the color change on scroll, and
  2. different titles for expanded and collapsed state by either:

The following video shows an example of animated color transition I would like to achieve.

example.MP4

Note

I am willing to implement this if it receives a green light, however details whether color change should be animated or not and which of the three options for point 2. is the best have to be discussed first.

Activity

  1. darshankawar
    added
    in triagePresently being triaged by the triage team
    on Mar 19, 2021

  2. darshankawar commented on Mar 19, 2021

    @darshankawar
    darshankawar
    on Mar 19, 2021
    Member

    @campovski Hi,
    Does this open issue sound similar to yours ?

  3. darshankawar
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Mar 19, 2021

  4. campovski commented on Mar 19, 2021

    @campovski
    campovski
    on Mar 19, 2021
    ContributorAuthor

    @darshankawar Hm, it seems similar to my proposal but I think it is a different bug. I checked thi issue database and could not find a similar issue. On one side, implementing my proposal could, but not necessarily, fix the mentioned issue. However, fixing the mentioned issue cannot fix mine. If requested, I can fix the mentioned issue as I implement mine.

  5. no-response
    removed
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Mar 19, 2021

  6. darshankawar commented on Mar 22, 2021

    @darshankawar
    darshankawar
    on Mar 22, 2021
    Member

    Thanks @campovski for clarifying. Feel free to send a PR to fix your and the mentioned issue.

  7. darshankawar
    added
    p: material_uimaterial_ui package in flutter/packages
    frameworkflutter/packages/flutter repository. See also f: labels.
    c: proposalA detailed proposal for a change to Flutter
    c: new featureNothing broken; request for a new capability
    passed first triage
    and removed
    in triagePresently being triaged by the triage team
    on Mar 22, 2021

  8. campovski commented on Mar 22, 2021

    @campovski
    campovski
    on Mar 22, 2021
    ContributorAuthor

    @darshankawar Probably this should have "f: cupertino" instead of "f: material design"?

  9. darshankawar
    added
    p: cupertino_uicupertino_ui package in flutter/packages
    and removed
    p: material_uimaterial_ui package in flutter/packages
    on Apr 12, 2021

  10. 8 remaining items

  11. auto-submit
    added a commit that references this issue on Jul 3, 2024

    Cupertino transparent navigation bars (#149102)

    6e246ac
  12. victorsanni
    added a commit that references this issue on Jul 8, 2024

    Cupertino transparent navigation bars (flutter#149102)

    6583eb9
  13. victorsanni
    added this to Cupertino Refreshon Aug 22, 2024
  14. Piinks
    changed the title [-]`CupertinoSliverNavigationBar` improvements[/-] [+]`CupertinoSliverNavigationBar` and `CupertinoNavigationBar` should support background colors[/+] on Aug 22, 2024
  15. Piinks
    added
    P3Issues that are less important to the Flutter project
    on Aug 22, 2024

  16. Piinks commented on Aug 22, 2024

    @Piinks
    Piinks
    on Aug 22, 2024
    Contributor

    I've updated this issue to reflect the first feature request, to make the issue singular and actionable. The second feature request is now reflected in:

  17. Piinks
    moved this to Todo in Cupertino Refreshon Aug 26, 2024

  18. victorsanni commented on Sep 27, 2024

    @victorsanni
    victorsanni
    on Sep 27, 2024
    Contributor

    Hi @campovski, @meg4cyberc4t, is this still an issue? If I set a background color for the CupertinoPageScaffold (for the expanded state), and a background color for the CupertinoSliverNavigationBar (for the collapsed state), the nav bar is able to lerp between both colors:

    nav.bar.background.colors.mov
  19. victorsanni
    added
    waiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds
    on Oct 12, 2024

  20. victorsanni commented on Oct 26, 2024

    @victorsanni
    victorsanni
    on Oct 26, 2024
    Contributor

    The first part of this issue was resolved in #149102, while the second part was resolved in #113544.

  21. victorsanni
    closed this as completedon Oct 26, 2024
  22. github-project-automation
    moved this from Todo to Done in Cupertino Refreshon Oct 26, 2024
  23. darshankawar
    added
    r: fixedIssue is closed as already fixed in a newer version
    on Oct 28, 2024

  24. github-actions commented on Nov 11, 2024

    @github-actions
    github-actionsbot
    on Nov 11, 2024 – with GitHub Actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  25. github-actions
    locked as resolved and limited conversation to collaborators on Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projectc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packagesr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages teamwaiting for responseThe Flutter team cannot make further progress on this issue until the original reporter responds

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions