Skip to content

☂️ [Flake] Device lab tests and benchmarks sometimes don't start the test or benchmark. #79097

Closed

Description

@zanderso

#77931

#76163

Could use some more logs from the device to help with issue routing.

@xster

Activity

  1. zanderso commented on Mar 25, 2021

    @zanderso
    MemberAuthor

    Also #79095

  2. chinmaygarde commented on Mar 29, 2021

    @chinmaygarde
    Contributor

    The logs indicate "Last layer tree was null when screenshotting" after a successful isolate launch while paused with a subsequent resume. I don't think see how the could possible tell when the raster thread has received the layer tree to rasterize. So, IMO, there is a race between when the driver is attempting to screenshot the layer tree and the engine getting the request to render that tree. Or, it could just be the isolate was never unpaused.

  3. chinmaygarde commented on Mar 29, 2021

    @chinmaygarde
    Contributor

    cc @xster for routing.

  4. changed the title [-]Better logs from ios tests in devicelab[/-] [+]☂️ Better logs from ios tests in devicelab[/+] on Mar 29, 2021
  5. chinmaygarde commented on Mar 29, 2021

    @chinmaygarde
    Contributor

    Another instance is at #78920

  6. chinmaygarde commented on Mar 29, 2021

    @chinmaygarde
    Contributor

    Yet another instance #78805. The more we run into this kind of error, the more I think it is the driver not waiting for the successful resumption of the isolate as described in this VM service procotol method.

  7. changed the title [-]☂️ Better logs from ios tests in devicelab[/-] [+]☂️ [Flake] Device lab tests and benchmarks sometimes don't start the test or benchmark.[/+] on Mar 29, 2021
  8. chinmaygarde commented on Mar 29, 2021

    @chinmaygarde
    Contributor

    Another one #77102. Bumping up the priority as this seems like a widely prevalent issue with multiple harnesses.

  9. added
    P0Critical issues such as a build break or regression
    and removed on Mar 29, 2021
  10. 3 remaining items

  11. dnfield commented on Mar 29, 2021

    @dnfield
    Contributor

    The 8 is fine, and the 11 is fine after a restart. I wonder if there's something going on where the phone(s) get clogged up and take longer to start sometimes, perhaps longer than the 30s timeout allows.

  12. dnfield commented on Mar 29, 2021

    @dnfield
    Contributor

    Updating the recipes here so that we always upload whatever timelines we get: https://flutter-review.googlesource.com/c/recipes/+/11622

    Updating the timeline API here so that we always write the raw timeline before trying to summarize it, and a summary failure will leave us at least with the raw timeline: #79310. This covers at least cases where we get a failure in summarization that blows up the test, especially if the test itself tried to summarize before dumping the timeline.

  13. dnfield commented on Mar 31, 2021

    @dnfield
    Contributor

    As of now, all the tests affected should be uploading at least a timeline in the LUCI UI. For the failures where the VM is starting but we get a white screen, that will hopefully give us a little more information about what point we're getting to before it hangs up.

  14. dnfield commented on Mar 31, 2021

    @dnfield
    Contributor

    #79310 will fix potential bugs where we'd miss a timeline because we try to summarize a timeline that had no frames.

  15. xster commented on Mar 31, 2021

    @xster
    Member

    @jmagman I think this is related to what we were chatting about last week, for driver tests, whether on the side to also just dump syslog to stdout or to another file for more debugging information.

  16. dnfield commented on Mar 31, 2021

    @dnfield
    Contributor

    Ok, we should now pretty much always be uploading a timeline if the VM is available - if we're still seeing failures where the timeline doesn't get uploaded we can look at beefing that up too.

    Since I'm not regularly seeing failures around this right now, I'm going to deprioritize this. And since I don't have any further action steps to take I'm going to unassign. Leaving open for now in case we continue to see this happen over the next week.

  17. removed their assignment
    on Mar 31, 2021
  18. added
    P2Important issues not at the top of the work list
    and removed
    P0Critical issues such as a build break or regression
    on Mar 31, 2021
  19. zanderso commented on Apr 28, 2021

    @zanderso
    MemberAuthor

    Since @dnfield has landed a change to get better logs and timelines, this probably makes more sense to track on a case-by-case basis, now, for example in #77193.

  20. github-actions commented on Aug 2, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  21. locked as resolved and limited conversation to collaborators on Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.c: flakeTests that sometimes, but not always, incorrectly passengineflutter/engine related. See also e: labels.platform-iosiOS applications specifically

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions