Skip to content

Add mac m1 machines to the staging pool #79430

Closed
Closed
Add mac m1 machines to the staging pool#79430
Assignees
godofredoc
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

Description

@godofredoc
godofredoc
opened on Mar 31, 2021

This requires the following:

  • Changes to salt states to install arm64 and x64 brew packages.
  • Add the mac configurations to the staging pool.
  • Fix any problems with the tests find

Activity

  1. godofredoc
    added
    team-infraOwned by Infrastructure team
    on Mar 31, 2021

  2. godofredoc commented on Mar 31, 2021

    @godofredoc
    godofredoc
    on Mar 31, 2021
    ContributorAuthor

    \cc @jmagman @xster

  3. pedromassangocode
    added
    c: contributor-productivityTeam-specific productivity, code health, technical debt.
    passed first triage
    on Mar 31, 2021

  4. godofredoc commented on Apr 1, 2021

    @godofredoc
    godofredoc
    on Apr 1, 2021
    ContributorAuthor

    flutter-devicelab-mac-4 is ready but it seems to be failing tasks:

  5. godofredoc
    assigned
    jmagman
    on Apr 1, 2021

  6. jmagman commented on Apr 1, 2021

    @jmagman
    jmagman
    on Apr 1, 2021
    Member

    https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8851131712845907728/+/steps/run_flutter_gallery_ios__start_up/0/stdout

     /usr/bin/arch -arm64e xcrun cc -arch arm64 -isysroot ...
arch: posix_spawnp: xcrun: Bad CPU type in executable

    These might need Rosetta installed. Can you add softwareupdate --install-rosetta to the setup?

  7. jmagman commented on Apr 1, 2021

    @jmagman
    jmagman
    on Apr 1, 2021
    Member

    @godofredoc says "rosetta is installed as part of the provisioning. idevice requires the emulation"

    Can we confirm whatever xcrun is on the PATH contains arm64e?

    $ which xcrun
/usr/bin/xcrun
$ file /usr/bin/xcrun      
/usr/bin/xcrun: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/usr/bin/xcrun (for architecture x86_64):	Mach-O 64-bit executable x86_64
/usr/bin/xcrun (for architecture arm64e):	Mach-O 64-bit executable arm64e

    (note the arm64e at the end).

  8. godofredoc commented on Apr 1, 2021

    @godofredoc
    godofredoc
    on Apr 1, 2021
    ContributorAuthor

    This is from the one included in the bundle:

    file /opt/flutter/xcode/12c33/XCode.app/Contents/Developer/usr/bin/xcrun
/opt/flutter/xcode/12c33/XCode.app/Contents/Developer/usr/bin/xcrun: Mach-O 64-bit executable x86_64

  9. godofredoc commented on Apr 1, 2021

    @godofredoc
    godofredoc
    on Apr 1, 2021
    ContributorAuthor

    It was that removing /opt/flutter/xcode/12c33/XCode.app/Contents/Developer/usr/bin/xcrun and re-running:

    https://luci-milo.appspot.com/p/flutter/builders/prod/Mac_ios_staging%20flutter_gallery_ios__start_up/135?

  10. jmagman commented on Apr 1, 2021

    @jmagman
    jmagman
    on Apr 1, 2021
    Member

    So is the next step a recipe change, or is there more for me to investigate, @godofredoc?

  11. godofredoc commented on Apr 1, 2021

    @godofredoc
    godofredoc
    on Apr 1, 2021
    ContributorAuthor

    Thanks for helping us identify the issue the next step is to create a new xcode bundle that does not include xcrun. I'll reassign the bug back to me.

  12. godofredoc
    assigned
    godofredoc
    and unassigned
    jmagman
    on Apr 1, 2021
  13. godofredoc
    added
    passed secondary triage
    on Apr 1, 2021

  14. godofredoc commented on Apr 1, 2021

    @godofredoc
    godofredoc
    on Apr 1, 2021
    ContributorAuthor

    Uploading a new xcode bundle to remove xcrun.

  15. godofredoc commented on Apr 2, 2021

    @godofredoc
    godofredoc
    on Apr 2, 2021
    ContributorAuthor

    @jmagman we still have a couple of failures:

    [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [  +20 ms] Building macOS application... (completed in 30.4s)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [  +11 ms] executing: /usr/bin/plutil -convert json -o - /opt/s/w/ir/tmp/t/edited_flutter_gallery/build/macos/Build/Products/Debug/flutter_gallery.app/Contents/Info.plist
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [  +25 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /opt/s/w/ir/tmp/t/edited_flutter_gallery/build/macos/Build/Products/Debug/flutter_gallery.app/Contents/Info.plist
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [        ] {"CFBundleName":"flutter_gallery","DTXcode":"1230","DTSDKName":"macosx11.1","NSHumanReadableCopyright":"Copyright © 2019 com.example. All rights reserved.","DTSDKBuild":"20C63","CFBundleDevelopmentRegion":"en","CFBundleVersion":"1","BuildMachineOSBuild":"20C69","NSPrincipalClass":"NSApplication","CFBundleIconName":"AppIcon","CFBundlePackageType":"APPL","CFBundleIconFile":"AppIcon","CFBundleSupportedPlatforms":["MacOSX"],"DTPlatformName":"macosx","CFBundleShortVersionString":"1.0.0","NSMainNibFile":"MainMenu","CFBundleInfoDictionaryVersion":"6.0","CFBundleExecutable":"flutter_gallery","DTCompiler":"com.apple.compilers.llvm.clang.1_0","CFBundleIdentifier":"com.example.flutterGallery","DTPlatformVersion":"11.1","DTXcodeBuild":"12C33","LSMinimumSystemVersion":"10.11","DTPlatformBuild":"12C33"}
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr: [+1012 ms] Error waiting for a debug connection: The log reader stopped unexpectedly.
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr: [   +2 ms] Error launching application on macOS.
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [   +2 ms] "flutter run" took 55,078ms.
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr: [   +5 ms] 
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:663:9)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #2      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1043:27)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #3      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #4      CommandRunner.runCommand (package:args/command_runner.dart:196:13)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #5      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:290:9)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #7      FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:238:5)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #8      run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            #10     main (package:flutter_tools/executable.dart:91:3)
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr:            <asynchronous suspension>
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr: 
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stderr: 
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [   +4 ms] ensureAnalyticsSent: 0ms
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [   +1 ms] Running shutdown hooks
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [        ] Shutdown hooks complete
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] stdout: [        ] exiting with code 1
 [hot_mode_dev_cycle_macos_target__benchmark] [STDOUT] "/opt/s/w/ir/k/recipe_cleanup/tmp0obZOn/flutter sdk/bin/flutter" exit code: 1

  16. jmagman commented on May 12, 2021

    @jmagman
    jmagman
    on May 12, 2021
    Member

    I was able to reproduce ios_app_with_extensions_test locally, investigating that now.

    hot_mode_dev_cycle_macos_target__benchmark passed on my machine. @godofredoc Is there a user logged in when that test runs?

  17. jmagman commented on May 13, 2021

    @jmagman
    jmagman
    on May 13, 2021
    Member

    I'm tracking the ios_app_with_extensions_test test failure in #82402

  18. jmagman commented on Jun 23, 2021

    @jmagman
    jmagman
    on Jun 23, 2021
    Member

    @godofredoc I'm about to merge a fix for the last test failure with #85087. I think getting an M1 set up in CI will be the last thing blocking iOS arm64 simulator work #85059.

  19. jmagman commented on Jun 23, 2021

    @jmagman
    jmagman
    on Jun 23, 2021
    Member

    #85087 merged, though I can't see if the tests now pass because mac-4 is quarantined for lack of disk space #82492.

  20. jmagman commented on Jun 30, 2021

    @jmagman
    jmagman
    on Jun 30, 2021
    Member

    Filed #85654 to track down the hot_mode_dev_cycle_macos_target__benchmark failure.

  21. godofredoc commented on Jul 29, 2021

    @godofredoc
    godofredoc
    on Jul 29, 2021
    ContributorAuthor

    @jmagman @keyonghan I believe we can close this issue, am I right? I see tests running on the Mac M1 machines.

  22. jmagman commented on Jul 29, 2021

    @jmagman
    jmagman
    on Jul 29, 2021
    Member

    I think so. Once I track down #85654 I'll file an issue to move the machines to the prod pool. Is that right, @godofredoc?

  23. godofredoc commented on Jul 29, 2021

    @godofredoc
    godofredoc
    on Jul 29, 2021
    ContributorAuthor

    Sounds good, thanks Jenn.

  24. godofredoc
    closed this as completedon Jul 29, 2021

  25. github-actions commented on Aug 12, 2021

    @github-actions
    github-actionsbot
    on Aug 12, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  26. github-actions
    locked as resolved and limited conversation to collaborators on Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions